Comment 1 for bug 1330973

Revision history for this message
Michael Terry (mterry) wrote :

Comments:
- There is a commented out override_dh_auto_test section. Though there are no shipped tests. Did there used to be tests?
- /usr/share/openstack-pkg-tools/pkgos.make is not included among the build-depends. It's marked as optional, so no biggie, but just wanted to confirm it's not desired for LP builds.
- You override a lot of dh_* commands with no-ops. That's fine, though a tad unusual. Were the commands causing problems?
- No big deal, but it doesn't build twice cleanly. Leaves files in build/
- We're in sync with Debian, yay
- No bugs in Debian or Ubuntu
- Has a team bug subscriber, thanks
- I like the python3 package

I would appreciate answers to my questions, but package as-is seems OK for promotion. Approved.