Comment 9 for bug 2029952

Revision history for this message
Robie Basak (racb) wrote :

> [Where problems could occur]

FTR, I was concerned about any OOM type conditions that might be introduced especially if controllable by a third party, but I saw this in the patch description:

> Also, since `msgpack` is only being used by the internal API, we're not worried about a third party coming in and overwhelming the system by deserializing calls.

However https://bugs.launchpad.net/ubuntu/+source/python-oslo.privsep/+bug/1896734/comments/37 talks of large number of ports. Is there any similar "large numbers" situation in which this change might introduce an OOM condition in practice, when it didn't before?

Accepting regardless - that's just something to look out for in consideration of testing. If you think it can't occur then it's fine :)