secrecy information failing to load

Bug #227537 reported by Kees Cook
6
Affects Status Importance Assigned to Milestone
python-launchpad-bugs
Fix Released
Medium
Unassigned
Hardy
Invalid
Undecided
Unassigned
python-launchpad-bugs (Ubuntu)
Fix Released
Low
Brian Murray
Hardy
Fix Released
Low
Brian Murray

Bug Description

Binary package hint: python-launchpad-bugs

  File "/scratch/ubuntu/vcs/python-launchpad-bugs/launchpadbugs/html_bug.py", line 853, in parse
   assert self.__xml, "Wrong XPath-Expr in Secrecy.parse() '__xml' (%s)" %(DEBUG_URL or "unknown")
AssertionError: Wrong XPath-Expr in Secrecy.parse() '__xml' (https://launchpad.net/bugs/226221)

Looks like something changed in the parsing of secrecy details.

Impact:
By default python-launchpad-bugs uses the text interface for gathering information about a bug and this only affects the html interface. However, due to secrecy and boardComment changes p-l-b is broken when parsing in html mode.

TEST CASE:
1) Execute 'buginfo --lastcomment --parsemode=html 227537' and watch bughelper crash.
2) Install the proposed version of python-launchpad-bugs
3) Execute 'buginfo --lastcomment --parsemode=html 227537' and bughelper should not crash

Revision history for this message
Brian Murray (brian-murray) wrote :

Kees commited a fix for this to revision 89 of python-launchpad-bugs. However, this needs to be fixed for Hardy.

Changed in python-launchpad-bugs:
importance: Undecided → Medium
status: New → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

The same launchpad rollout broke comment parsing in html_bug.py. The div now has a class of "boardComment ". I committed a robust fix to rev 90 of python-launchpad-bugs but this too needs fixing in Hardy.

Changed in python-launchpad-bugs:
importance: Undecided → Low
status: New → Confirmed
assignee: nobody → brian-murray
status: Confirmed → In Progress
assignee: nobody → brian-murray
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-launchpad-bugs - 0.2.31

---------------
python-launchpad-bugs (0.2.31) intrepid; urgency=low

  [ Markus Korn ]
  * launchpadbugs/attachmentsbase.py, launchpadbugs/html_bug.py:
    always parse attachments before parsing comments in the html-mode.
    (LP: #215043)

  [ Kees Cook ]
  * launchpadbugs/html_bug.py: extract Secrecy from 'big-badges'.
    (LP: #227537)

  [ Brian Murray ]
  * launchpadbugs/html_bug.py: made boardComment xpath more robust.
    (LP: #227537)

 -- Brian Murray <email address hidden> Tue, 06 May 2008 21:12:20 -0700

Changed in python-launchpad-bugs:
status: In Progress → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

debdiff for Hardy proposed

description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

New debdiff that'll fix this bug and bug 235681.

Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into -proposed, please test and give feedback here

Changed in python-launchpad-bugs:
status: In Progress → Fix Committed
Revision history for this message
Markus Korn (thekorn) wrote :

The version of python-launchpad-bugs in -proposed (0.2.30.1) fixes this bug for me.

[with 0.2.30]
markus@thekorn:~$ buginfo --lastcomment --parsemode=html 227537
Traceback (most recent call last):
  File "/usr/bin/buginfo", line 83, in <module>
    main()
  File "/usr/bin/buginfo", line 67, in main
    comment = comments[int(cnr)]
IndexError: list index out of range

[with 0.2.30.1]
markus@thekorn:~$ buginfo --lastcomment --parsemode=html 227537
<Comment #6 by pitti on 2008-06-05 05:46:45 UTC>

Markus

Revision history for this message
Martin Pitt (pitti) wrote :

Copied to hardy-updates.

Changed in python-launchpad-bugs:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.