new LP rollout broke subscription

[Martin Pitt]

Attached reproducer script demonstrates a crash when trying to subscribe someone to a bug. This happened with last night's LP rollout.

$ python /tmp/sub-crash.py /home/martin/.lpcookie
Traceback (most recent call last):
  File "/tmp/sub-crash.py", line 8, in <module>
    bug.commit()
  File "/usr/lib/python2.5/site-packages/launchpadbugs/html_bug.py", line 1268, in commit
    result = i.component.commit(force_changes, ignore_lp_errors)
  File "/usr/lib/python2.5/site-packages/launchpadbugs/html_bug.py", line 945, in commit
    self._add(i)
  File "/usr/lib/python2.5/site-packages/launchpadbugs/html_bug.py", line 959, in _add
    raise ValueError, "Unknown error while subscribe %s to %s" %(lplogin, url)
ValueError: Unknown error while subscribe sru-verification to https://bugs.edge.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/228519/+addsubscriber

(Both with current hardy version and trunk bzr head).

[Markus Korn (thekorn)]

fix against rev. 93

[Markus Korn (thekorn)]

------------------------------------------------------------
revno: 94
committer: markus korn <markus@thekorn>
branch nick: main
timestamp: Thu 2008-05-29 09:24:17 +0200
message:
  launchpadbugs/html_bug.py: fixed adding new subscribers (LP: #235681)
------------------------------------------------------------

[Daniel Holbach (dholbach)]

Are there any plans to SRU this fix or get it into PPA at least? :-)

[Brian Murray (brian-murray)]

Attached is a debdiff for Hardy proposed that addresses this bug and bug 227537.

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-launchpad-bugs - 0.2.33

---------------
python-launchpad-bugs (0.2.33) intrepid; urgency=low

  [ Markus Korn ]
  * launchpadbugs/lphelper.py: fixed html-parser for Dapper again,
    workaround for broken libxml2 (LP: #220679)
  * launchpadbugs/html_bug.py: fixed adding new subscribers (LP: #235681)

 -- Brian Murray <email address hidden> Wed, 04 Jun 2008 15:26:35 -0700

[Martin Pitt (pitti)]

Accepted into -proposed, please test and give feedback here

[Markus Korn (thekorn)]

The version of python-launchpad-bugs in -proposed (0.2.30.1) fixes this bug for me.

[with 0.2.30]
In [1]: from launchpadbugs.connector import ConnectBug

In [2]: Bug = ConnectBug()

In [3]: Bug.authentication = "/home/markus/.mozilla/firefox/iy3ore6m.default/cookies.sqlite"

In [4]: b = Bug(234363)

In [5]: b.subscribers.add("thekorn")

In [6]: xmode
Exception reporting mode: Verbose

In [7]: xmode
Exception reporting mode: Plain

In [8]: b.commit()
------------------------------------------------------------
Traceback (most recent call last):
  File "<ipython console>", line 1, in <module>
  File "/usr/lib/python2.5/site-packages/launchpadbugs/html_bug.py", line 1268, in commit
    result = i.component.commit(force_changes, ignore_lp_errors)
  File "/usr/lib/python2.5/site-packages/launchpadbugs/html_bug.py", line 945, in commit
    self._add(i)
  File "/usr/lib/python2.5/site-packages/launchpadbugs/html_bug.py", line 959, in _add
    raise ValueError, "Unknown error while subscribe %s to %s" %(lplogin, url)
<type 'exceptions.ValueError'>: Unknown error while subscribe thekorn to https://bugs.edge.launchpad.net/buglog-data/+bug/234363/+addsubscriber

[with 0.2.30.1]
In [1]: from launchpadbugs.connector import ConnectBug

In [2]: Bug = ConnectBug()

In [3]: Bug.authentication = "/home/markus/.mozilla/firefox/iy3ore6m.default/cookies.sqlite"

In [4]: b = Bug(234363)

In [5]: b.subscribers.add("thekorn")

In [6]: xmode plain
Exception reporting mode: Plain

In [7]: b.commit()

In [8]: b = Bug(234363)

In [9]: b.subscr
b.subscribers b.subscribtions b.subscriptions

In [9]: b.subscribers
Out[9]: <Subscribers>

In [10]: print b.subscribers
set([<user dholbach (Daniel Holbach)>, <user thekorn (Markus Korn)>])

Markus

[Martin Pitt (pitti)]

Copied to hardy-updates.

[Jamie Strandboge (jdstrand)]

This update fixed my tracebacks when using things like:

if not 'ubuntu-bugs' in bug.subscriptions:
     bug.subscribers.add("ubuntu-bugs")