Ubuntu
python-certbot-nginx package

  1. Bug #1875471
  2. Comment #15

Comment 15 for bug 1875471

Revision history for this message
Brad Warren (bradmwarren) wrote :

To offer one other option based on my previous comments while trying to keep things simple, I think in the short term you could also go with:

d) Update just python-certbot-nginx to 0.40.0 and apply this patch to python-certbot-nginx's tests: https://gist.github.com/bmw/e4f13e17d1f4647c9d6be730c7ec3512. This change is the only changes to the files shipped in the nginx package from https://github.com/certbot/certbot/commit/4abd81e2186eddc67551d61a8260440bd177d18d.

This option would fix the user facing problems in the nginx plugin and its tests without modifying any other packages.

In the long term, I'm personally in favor of updating things as much as we can and doing as little backporting of commits as possible, but I'm fine with any of the approaches in the short term.

I'll start looking into the test failures now.