Comment 8 for bug 2001699

Revision history for this message
Lukas Märdian (slyon) wrote (last edit ):

Re-Review for source package: python-inflect

Even though this is a big version bump (2.1.0-4 -> 6.0.4-1) the initial MIR review in comment #2 still holds true. The diff between 2.1 and 6.0 looks sane and manageable. Nothing unexpected (like a full rewrite or anything).

Most of the required TODOs have been addressed:
#6 resolved
#5 resolved
#4 resolved
#3 resolved
#2 downgrade to Recommended
#1 downgrade to Recommended

=> MIR team ACK. No need for security review.
=> This is after its dependencies are resolved:
-- pydantic MIR (LP: #2001699)
-- -- python-typing-extensions MIR (LP: #2002821)

I'd still recommend to look into the following issues:

#1 Update to the current version 7.0.0 (as of 2023-07-11)
-- we're only 3 months behind now, that seems OKish.
-- Therefore, this requirement is downgraded to a Recommended TODO

#2 Agree to keep it updated/maintained in Debian/Ubuntu
-- Maintenance in Debian seems sporadic, the OpenStack team might want to help to keep the package up-to-date
-- Though, good work is being done (adding autotests, fixing deprecation warnings), so this requirement is downgraded to a Recommended TODO

#7 Lintian warnings, somebody might look into:
-- I: python-inflect source: older-debian-watch-file-standard 3 [debian/watch]