© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Hi Andreas,
Follow on from our IRC conversation, I've revisited and fixed the Xenial branch. Thank you for such a thorough review, and for catching those mistakes. What we're seeing here are simply mistakes on my behalf, when working to move my patches to Salsa - the debdiffs were generated at this point also. So I appreciate your work to validate and test the provided branches and diffs. I've addressed the Xenial case but also your feedback on the Bionic and Disco branches. The intention here was indeed to try and keep the branches similar to reduce backport-burden, however I can see the value in more tightly specifying the debhelper version also, so I've updated that and fixed the consistency mistakes around version (compat vs control vs changelog).
Hi Brad,
Thanks for jumping in again and adding more context around the upstream testing that has occurred around older versions. I had alluded to this backwards compatibility testing in my IRC conversation with Andreas, so the additional detail is very helpful.
Now, to the changes I have made, and the testing I have no done and re-done:
- Xenial: changelog has been updated to reflect the changes to the python dependency versions
- Xenial: requirement for python(
- Xenial: requirement for python(3)-idna packages have been lowered to 2.0
- Xenial: debhelper version has been made consistent between changelog, control and compat (v9)
- Bionic: debhelper version has been returned to the original 11 in control, compat and changelog
- Disco: debhelper version has been returned to the original 11 in control, compat and changelog
And, to the testing I have performed on the updated branches:
- Xenial: Full clean rebuild of the package from the current ubuntu-xenial branch [0] of my salsa repo, this was successful with the changes above, and the test suite runs successfully.
- Xenial: I took the built package and updated one of my servers running Xenial which uses Certbot to managed TLS certificates. I was able to, using the distro packages (no PPA) upgrade successfully to the backported package, and execute a renewal against the test ACME endpoint. This successfully renewed and the debug log shows the v2 endpoint being used successfully.
- Bionic: Full clean rebuild of the package from the ubuntu-bionic branch of my salsa repo [1], and the test suite ran successfully
- Disco: Full clean rebuild of the package from the ubuntu-disco branch of my salsa repo [2], and the test suite ran successfully
Please let me know if any further changes or testing is required. I believe I have addressed the feedback raised so far and have tested each change, but if I've missed anything, let me know.
[0] https:/
[1] https:/
[2] https:/