Comment 51 for bug 486154

Revision history for this message
Robert Schroll (rschroll) wrote :

> Confirmed---your patch fixes the issue.

Good to hear!

> Strictly speaking, I don't think you need part 3 of your patch

I this is correct. Part 3 only re-enables the gconf /apps/metacity/general/audible_bell key to turn the bell on and off. Whether metacity *should* have a key to do this, I don't know. But given that it *does* have this key, I think we ought to make it work. Also, I suspect that, without change #3, if this key is set to false when metacity starts, metacity will trap audible bells irrevocably. (I suspect meta_prefs_bell_is_audible() will return False, causing the last argument of XkbChangeEnabledControls() to be 0, which we know will trap the audible bells. But at this point, I don't feel like risking breaking things again to check this hunch.)

> I suspect somebody should open a bug upstream,

I was going to wait a few days to see if WeatherGod can scare up someone from Ubuntu to comment on this patch. I suspect that we'd get a better reception from the Metacity people if we can show this is desired by the Ubuntu project, rather than just a few random cranky users. But it anyone feels like taking the initiative and posting this to metacity's bug tracker before I do, please be my guest!