pulseaudio built with --enable-snappy but 'Enable Snappy support: no'

Bug #1781428 reported by Jamie Strandboge on 2018-07-12
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pulseaudio (Ubuntu)
Undecided
James Henstridge
Nominated for Bionic by James Henstridge
Nominated for Xenial by James Henstridge

Bug Description

From https://launchpadlibrarian.net/377100864/buildlog_ubuntu-cosmic-amd64.pulseaudio_1%3A12.0-1ubuntu1_BUILDING.txt.gz:

...
dh_auto_configure -- --enable-x11 --disable-hal-compat --libdir=\${prefix}/lib/x86_64-linux-gnu --with-module-dir=\${prefix}/lib/pulse-12.0/modules --with-zsh-completion-dir=\${datadir}/zsh/vendor-completions --with-bash-completion-dir=\${datadir}/bash-completion/completions --with-systemduserunitdir=\${prefix}/lib/systemd/user --enable-snappy --disable-bluez4 --enable-gsettings --disable-gconf
 ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --enable-x11 --disable-hal-compat --libdir=\${prefix}/lib/x86_64-linux-gnu --with-module-dir=\${prefix}/lib/pulse-12.0/modules --with-zsh-completion-dir=\${datadir}/zsh/vendor-completions --with-bash-completion-dir=\${datadir}/bash-completion/completions --with-systemduserunitdir=\${prefix}/lib/systemd/user --enable-snappy --disable-bluez4 --enable-gsettings --disable-gconf
...
    Enable Ubuntu trust store: no
    Enable Snappy support: no
    Enable Apparmor: yes

At this point, the patch should probably be dropped, otherwise applications like chromium, etc will no longer be able to record.

Related branches

description: updated
Daniel van Vugt (vanvugt) wrote :

I'm not familiar with the workings of those patches - only basic fixes to make them build OK.

Certainly "Enable Snappy support: no" looks like a bug worth fixing. But I don't know who has the authority to decide about dropping any of those patches.

Also how does this relate to Chromium?

Changed in pulseaudio (Ubuntu):
status: New → Incomplete
Jamie Strandboge (jdstrand) wrote :

We can't just enable the patches any more because it will change how snaps that plugs 'pulseaudio' will work. Put concretely, the patches are meant to detect if the connecting process is a snap and if it is, unconditionally deny recording. Some snaps that 'plugs: [ pulseaudio ]' have legitimate use for audio recording, such as the chromium and firefox snaps for Google Meet, etc. If these patches all of a sudden were fixed, then snaps like firefox and chromium would no longer be able to record audio.

While Ubuntu will end up patching pulseaudio in some way to support record mediation, it won't be with these patches. This is being discussed in https://forum.snapcraft.io/t/pulseaudio-recording/6361. If you have experience with pulseaudio and are interested in the upcoming changes, please keep an eye on the forum (and ideally participate in the conversation). Thanks!

Changed in pulseaudio (Ubuntu):
status: Incomplete → New
Changed in pulseaudio (Ubuntu):
assignee: nobody → James Henstridge (jamesh)
status: New → In Progress
James Henstridge (jamesh) wrote :

Attached is a debdiff for a 1:12.2-0ubuntu2 release of pulseaudio with an updated snap policy module and the default configuration modified to enable it.

I also took the opportunity to remove the Ubuntu Phone era trust-store module, which hasn't been built since February.

The attachment "pulseaudio_12.2-0ubuntu1_12.2-0ubuntu2.diff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pulseaudio - 1:12.2-0ubuntu2

---------------
pulseaudio (1:12.2-0ubuntu2) cosmic; urgency=medium

  * Update snap policy to make access to audio recording conditional on
    plugging the "pulseaudio" or "audio-record" interfaces (LP: #1781428):
    - 0700-modules-add-snappy-policy-module.patch: rewrite to query
      snapd for the client's plugged interfaces.
    - 0701-enable-snap-policy-module.patch: enable the module in the
      default configuration.
    - Build depend on libsnapd-glib-dev.
  * Remove module-trust-store patch set:
    - 0409-Trust-store-patch.patch: trimmed down to pulsecore changes.
    - 0410-Add-thread-to-activate-trust-store-interface.patch: removed.
    - 0417-increase-timeout-check-apparmor.patch: removed.

 -- James Henstridge <email address hidden> Tue, 07 Aug 2018 17:01:22 +0800

Changed in pulseaudio (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers