| 2016-07-05 14:50:29 |
bugproxy |
bug |
|
|
added bug |
| 2016-07-05 14:50:33 |
bugproxy |
tags |
|
architecture-ppc64le bugnameltc-143371 severity-high targetmilestone-inin16041 |
|
| 2016-07-05 14:50:34 |
bugproxy |
ubuntu: assignee |
|
Taco Screen team (taco-screen-team) |
|
| 2016-07-05 14:50:37 |
bugproxy |
affects |
ubuntu |
powerpc-ibm-utils (Ubuntu) |
|
| 2016-07-05 22:45:00 |
Steve Langasek |
affects |
powerpc-ibm-utils (Ubuntu) |
powerpc-utils (Ubuntu) |
|
| 2016-07-05 22:55:00 |
Steve Langasek |
nominated for series |
|
Ubuntu Xenial |
|
| 2016-07-05 22:55:00 |
Steve Langasek |
bug task added |
|
powerpc-utils (Ubuntu Xenial) |
|
| 2016-07-06 00:10:30 |
Launchpad Janitor |
powerpc-utils (Ubuntu): status |
New |
Fix Released |
|
| 2016-07-06 08:35:44 |
Andy Whitcroft |
powerpc-utils (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2016-07-06 08:35:45 |
Andy Whitcroft |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2016-07-06 08:35:52 |
Andy Whitcroft |
bug |
|
|
added subscriber SRU Verification |
| 2016-07-06 08:35:55 |
Andy Whitcroft |
tags |
architecture-ppc64le bugnameltc-143371 severity-high targetmilestone-inin16041 |
architecture-ppc64le bugnameltc-143371 severity-high targetmilestone-inin16041 verification-needed |
|
| 2016-07-06 15:27:58 |
Steve Langasek |
description |
---Problem Description---
update_flash -d option is throwing [: x47: unexpected operator message
---uname output---
Linux ltc-garri2 4.4.0-30-generic #49-Ubuntu SMP Fri Jul 1 10:00:36 UTC 2016 ppc64le ppc64le ppc64le GNU/Linux
Machine Type = P8
---Steps to Reproduce---
Install a P8 8335-GTB Hardware with Ubuntu 16.04.1 OS.
Then execute the below command to check the version of the firmware installed on the machine.
root@ltc-garri2:~# update_flash -d
/usr/sbin/update_flash_nv: 595: [: x47: unexpected operator
Firmware version:
Product Name : OpenPOWER Firmware
Product Version : IBM-garrison-ibm-OP8_v1.9_2.1
Product Extra : op-build-dcacfac
Product Extra : buildroot-bc248fa
Product Extra : skiboot-5f25590
Product Extra : hostboot-4c63029-6034fa6
Product Extra : linux-4.4.9-openpower2-ebc7b6d
Product Extra : petitboot-v1.1.1-fc477ec
Product Extra : garrison-xml-b453a81
Product Extra : occ-19a3ebc
Product Extra : hostboot-binar
root@ltc-garri2:~# echo $?
0
root@ltc-garri2:~# which update_flash
/usr/sbin/update_flash
root@ltc-garri2:~# dpkg -S /usr/sbin/update_flash
powerpc-ibm-utils: /usr/sbin/update_flash
root@ltc-garri2:~# dpkg --list | grep powerpc-ibm-utils
ii powerpc-ibm-utils 1.3.1-2 ppc64el utilities for maintenance of IBM PowerPC platforms
Userspace tool common name: /usr/sbin/update_flash
The userspace tool has the following bit modes: 64-bit
Userspace package: powerpc-ibm-utils
Below upstream patch fixes this issue:
commit c3269d4e3d4882fd931d1df6aece0bec86fb6734
Author: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Date: Thu Jun 30 10:26:58 2016 -0400
update_flash: Fix bashism issue in opp_display_current_fw_version()
Ubuntu uses dash, not bash. We hit below warning on Ubuntu system.
root@abc:/sys/firmware/devicetree/base/ibm,opal/sensors# update_flash -d
/usr/sbin/update_flash_nv: 595: [: x43: unexpected operator
Firmware version:
....
....
== is a bashism. Replace it with =.
Fixes: 767e3dd7 (update_flash: Add support for OpenPower system)
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
-Vasant |
[SRU Justification]
On an OpenPower system, '/usr/sbin/update_flash_nv -d' will print a gratuitous error message, and will not correctly report failures to query the firmware version.
[Test case]
1. On an OpenPower system (as determined by the presence of the file /proc/device-tree/bmc), run 'sudo update_flash_nv -d'. Observe that an error message is printed before the version information.
2. Install powerpc-utils from xenial-proposed.
3. Run 'sudo update_flash_nv -d' again. Verify that no error message is printed.
[Regression potential]
Minimal. This is a targeted, one-line fix for a bashism in a shell script.
---Problem Description---
update_flash -d option is throwing [: x47: unexpected operator message
---uname output---
Linux ltc-garri2 4.4.0-30-generic #49-Ubuntu SMP Fri Jul 1 10:00:36 UTC 2016 ppc64le ppc64le ppc64le GNU/Linux
Machine Type = P8
---Steps to Reproduce---
Install a P8 8335-GTB Hardware with Ubuntu 16.04.1 OS.
Then execute the below command to check the version of the firmware installed on the machine.
root@ltc-garri2:~# update_flash -d
/usr/sbin/update_flash_nv: 595: [: x47: unexpected operator
Firmware version:
Product Name : OpenPOWER Firmware
Product Version : IBM-garrison-ibm-OP8_v1.9_2.1
Product Extra : op-build-dcacfac
Product Extra : buildroot-bc248fa
Product Extra : skiboot-5f25590
Product Extra : hostboot-4c63029-6034fa6
Product Extra : linux-4.4.9-openpower2-ebc7b6d
Product Extra : petitboot-v1.1.1-fc477ec
Product Extra : garrison-xml-b453a81
Product Extra : occ-19a3ebc
Product Extra : hostboot-binar
root@ltc-garri2:~# echo $?
0
root@ltc-garri2:~# which update_flash
/usr/sbin/update_flash
root@ltc-garri2:~# dpkg -S /usr/sbin/update_flash
powerpc-ibm-utils: /usr/sbin/update_flash
root@ltc-garri2:~# dpkg --list | grep powerpc-ibm-utils
ii powerpc-ibm-utils 1.3.1-2 ppc64el utilities for maintenance of IBM PowerPC platforms
Userspace tool common name: /usr/sbin/update_flash
The userspace tool has the following bit modes: 64-bit
Userspace package: powerpc-ibm-utils
Below upstream patch fixes this issue:
commit c3269d4e3d4882fd931d1df6aece0bec86fb6734
Author: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Date: Thu Jun 30 10:26:58 2016 -0400
update_flash: Fix bashism issue in opp_display_current_fw_version()
Ubuntu uses dash, not bash. We hit below warning on Ubuntu system.
root@abc:/sys/firmware/devicetree/base/ibm,opal/sensors# update_flash -d
/usr/sbin/update_flash_nv: 595: [: x43: unexpected operator
Firmware version:
....
....
== is a bashism. Replace it with =.
Fixes: 767e3dd7 (update_flash: Add support for OpenPower system)
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
-Vasant |
|
| 2016-07-07 04:29:23 |
bugproxy |
tags |
architecture-ppc64le bugnameltc-143371 severity-high targetmilestone-inin16041 verification-needed |
architecture-ppc64le bugnameltc-143371 severity-high targetmilestone-inin16041 verification-done |
|
| 2016-07-13 15:13:41 |
Launchpad Janitor |
powerpc-utils (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2016-07-13 15:13:47 |
Chris J Arges |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2016-07-21 07:20:23 |
bugproxy |
affects |
powerpc-utils (Ubuntu) |
powerpc-ibm-utils (Ubuntu) |
|
| 2016-07-21 14:56:11 |
Steve Langasek |
affects |
powerpc-ibm-utils (Ubuntu) |
powerpc-utils (Ubuntu) |
|
| 2016-07-21 15:42:41 |
bugproxy |
affects |
powerpc-utils (Ubuntu) |
powerpc-ibm-utils (Ubuntu) |
|
| 2016-07-22 06:19:56 |
Adam Conrad |
affects |
powerpc-ibm-utils (Ubuntu) |
powerpc-utils (Ubuntu) |
|
