Comment 3 for bug 1973382

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Hi Dave,

Thanks for the thoughtful reply!

> After all, if it's simulating a reinstallation, shouldn't it restart the service? [...]

Usually, yes, I agree it should restart the service. In this specific postgresql-common case, debian/rules was crafted so a restart would not happen at this point:

https://salsa.debian.org/postgresql/postgresql-common/-/blob/master/debian/rules#L27-31

Now, while the test suite regression is only present in Ubuntu (and not in Debian) due to the dpkg-reconfigure delta, a change of behavior was also introduced in the upgrade path due to the debhelper change at

https://salsa.debian.org/debian/debhelper/-/commit/742b0c5ac8f4a6cfcd699f08915a8109a5ebec35.

The service, which would be left untouched on postgresql-common upgrades, will now be stopped on upgrades.

Finally,

> You are certainly correct that [we should add --no-stop-on-upgrade option to dh_installsystemd?]

This would restore the previous, designed behavior of the package upgrade path. Still, the preinst script would differ from the Debian one. Therefore, I filed

https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/postgresql-common/+git/postgresql-common/+merge/422669

and will also file a Debian bug to include the Debian maintainers in the discussion before we do introduce the delta here.