Comment 15 for bug 1769888

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Test check:
- skytools3
This is reproducible locally with the pre-MRE version just as much.
Something "else" yet unknown must have changed
  test init_ext ... ok
  test londiste_provider ... ok
  test londiste_subscriber ... ok
  test londiste_fkeys ... ok
  test londiste_execute ... ok
  test londiste_seqs ... ok
  test londiste_merge ... ok
  test londiste_leaf ... ok
  test londiste_create_part ... FAILED
...
  select tgenabled, pg_get_triggerdef(oid) from pg_trigger where tgrelid = 'events_2011_01'::regclass::oid;
! tgenabled | pg_get_triggerdef
! -----------+-------------------------------------------------------------------------------------------------------------
! A | CREATE TRIGGER "Fooza" AFTER DELETE ON public.events_2011_01 FOR EACH ROW EXECUTE PROCEDURE "NullTrigger"()
  (1 row)

  -- test weird quoting

Comparing with old logs of the same test on 2017-11-24 doesn't reveal anything obvious at first and it seems to be just whitespaces but then I found the reason for the new indent (almost missed, thanks colordiff).
"events_2011_01" is now called "public.events_2011_01"
It could be that one of the security-pushed CVE changes modified that.

This change seems safe, so with the check adapted to expect the new prefix I retested.
And all is good, all further tests pass without further modification as well.

We can either co-SRU a change to skytools3 for the test or badtest the old version or now (or both).