Comment 0 for bug 1063613

Revision history for this message
Dan Searle (dan-censornet) wrote :

I found a bug in libecpg.so.6.3, which according to Michael Meskes was introduced in the postgresql 9.0 source tree.

I have included a test application which works fine on Postgresql 8.4 (libecpg.so.6.1), but fails using Postgresql 9.1 (libecpg.so.6.3).

After confirming the bug with Michael, he came up with this patch. Can it be added to the Ubuntu package sources please?...

commit 4f6469e55c8bf8b015fe571313c5922a869b4636
Author: Michael Meskes <email address hidden>
Date: Fri Oct 5 16:37:45 2012 +0200

    Fixed test for array boundary.

    Instead of continuing if the next character is not an array boundary get_data()
    used to continue only on finding a boundary so it was not able to read any
    element after the first.

diff --git a/src/interfaces/ecpg/ecpglib/data.c b/src/interfaces/ecpg/ecpglib/data.c
index db97503..dcccd92 100644
--- a/src/interfaces/ecpg/ecpglib/data.c
+++ b/src/interfaces/ecpg/ecpglib/data.c
@@ -422,6 +422,7 @@ ecpg_get_data(const PGresult *results, int act_tuple, int act_field, int lineno,
        ecpg_raise(lineno, ECPG_CONVERT_BOOL,
             ECPG_SQLSTATE_DATATYPE_MISMATCH,
             NULL);
+ pval++;
       break;
      }
      else if (pval[0] == 't' && pval[1] == '\0')
@@ -434,6 +435,7 @@ ecpg_get_data(const PGresult *results, int act_tuple, int act_field, int lineno,
        ecpg_raise(lineno, ECPG_CONVERT_BOOL,
             ECPG_SQLSTATE_DATATYPE_MISMATCH,
             NULL);
+ pval++;
       break;
      }
      else if (pval[0] == '\0' && PQgetisnull(results, act_tuple, act_field))
@@ -777,7 +779,7 @@ ecpg_get_data(const PGresult *results, int act_tuple, int act_field, int lineno,
      ++pval;
    }
   }
- } while (*pval != '\0' && array_boundary(isarray, *pval));
+ } while (*pval != '\0' && !array_boundary(isarray, *pval));

  return (true);
 }