Comment 14 for bug 80921

Revision history for this message
In , Carl Worth (cworth) wrote :

From the cairo point-of-view, a patch to poppler like this should
not be needed and should not be applied. If poppler is rendering
to a cairo-xlib surface and the user has requested sub-pixel rendered
fonts, (by configuring font preferences in GNOME or KDE dialogs or
whatever), then cairo should be doing subpixel rendering.

If it's not, then masking that bug by forcing the rendering on, (and
hard-coding a particular sub-pixel order), doesn't help anything and
will hurt any users that don't want this.

Please find the real problem, and we'll definitely want to fix it,
but please don't apply this patch.

-Carl

PS. Reading back over the original description of the patch, it sounds
like Anders is describing a real problem, (a non-integer clipping
rectangle being passed to cairo). For cairo, I'm still curious as to
why that should disable sub-pixel rendering, (that sounds like a bug).
But meanwhile, the right thing to do, and likely the easiest, is to
simply fix poppler to correctly round the crop box values to integers
before passing them to cairo. And yes, this should also improve
performance.