Comment 5 for bug 726224

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This seems to be the problematic bit of code (at line 2095 in glib/poppler-document.cc):
    } else if (orderItem.isString ()) {
      last_item->label = _poppler_goo_string_to_utf8 (orderItem.getString ());
    }

An extremely naive fix for this (from someone who hasn't looked at the code much) would be to do:
    } else if (last_item != NULL && orderItem.isString ()) {
      last_item->label = _poppler_goo_string_to_utf8 (orderItem.getString ());
    }

That may fix the crash, but may not render the text correctly. This appears to be just a crasher so am marking as non-security. Please re-mark this as security if this is a mistake.