Comment 4 for bug 724052

Revision history for this message
In , Nikki VonHollen (vonhollen) wrote :

Created attachment 54450
Added netgroup support and expanded unit tests with MockLibc

Please ignore the previous comment/attachment. I got the two bug numbers mixed up.

This patch relies on 'policykit-unittest.patch' from bug #43608.

There are a few issues I ran into implementing netgroups:
1. Netgroups can't support glob syntax like other identities do in *.pkla
files.
2. A netgroup with a wildcard entry like (,,), which means any
user/host/domain, will be ignored in the admin identities list.
3. I use git submodules to include the MockLibc source code, but I'm not sure
if that's what we should stick with. I can include code

Since I'm using submodules, the first commit with the submodule needs to run
'git submodule add' to put special metadata in the repo which can't happen via
patch AFAIK. For eaxmple:
cd PolicyKit
patch -p1 < ~/policykit-unittest.patch
patch -p1 < ~/policykit-netgroup.patch
git submodule add -b v1 https://code.google.com/p/mocklibc/ noinst/mocklibc