Ubuntu
policykit-1 package

  1. Bug #619632
  2. Comment #11

Comment 11 for bug 619632

Revision history for this message
In , Miloslav Trmac (mitr-redhat) wrote :

Thanks for the patch. The approach broadly makes sense, three points for now:

* The documentation should be updated as well.
* AFAICT _localize() is not handling the lang==NULL case correctly.
* The calls to setlocale() are worrisome; we do use threads at least in the JavaScript runtime. It seems that gettext can work with per-thread locales (uselocale()), OTOH that might not be portable. (Honestly not sure about this. Colin?)

(I haven’t reviewed the memory handling in detail