Comment 4 for bug 1842428

Checking https://github.com/pmem/pmdk/compare/1.3.1...1.3.3

https://github.com/pmem/pmdk/commit/456d9745ec628329b9cbaa1e7211f11e4b3035fd summarizes the changes introduced in 1.3.2:

* Version 1.3.2
 Bug fixes:
 - common: fix library dependencies (#767)
 - common: use rpm-config CFLAGS/LDFLAGS when building packages (#768)
 - test: fix vmmalloc_malloc_hooks (#773)
 - test: fix compilation with clang-5.0 (#783)
 - pool: fix set convert of v3 -> v4

Verified by inspection of the diff in https://github.com/pmem/pmdk/compare/1.3.1...1.3.3

1.3.2 wasn't released, so the final changelog only mentions 1.3.3:
https://github.com/pmem/pmdk/commit/6191ac4d494af5d6e5ac48944ea204da301829a7 (still rc1, but no changes to final)
* Version 1.3.3-rc1
 Bug fixes:
 - pmem: fix clflush bit position
 - common: implement correct / robust device_dax_alignment
 - common: fix device dax detection
 - common: fix library dependencies (#767)
 - common: use rpm-config CFLAGS/LDFLAGS when building packages (#768)
 - test: fix vmmalloc_malloc_hooks (#773)
 - test: fix compilation with clang-5.0 (#783)
 - pool: fix set convert of v3 -> v4
 - common: generate pkg-config files on make install (#610)
 - common: fix dependencies for Debian's dev packages
 - test: add missing include in unittest.h
 - common: (win) fix timed locks
 - common: provide src version in GitHub tarballs
 - common: fix free function in tls

All bug fixes.

Of the above, I looked into a bit more of detail into this one:

common: use system-default or user-defined CFLAGS
https://github.com/pmem/pmdk/commit/191bf70bca6dc438134365ee3491410fc5f24316

That is providing a set of DEFAULT_CFLAGS, and then doing this:
CFLAGS ?= $(DEFAULT_CFLAGS)

CFLAGS += -std=gnu99
CFLAGS += -fno-common
CFLAGS += -pthread
CFLAGS += -DSRCVERSION=\"$(SRCVERSION)\"

They did it to allow passing of CFLAGS into their own rpm builds, via https://github.com/pmem/pmdk/commit/957bff1598292cc3a294b40cd4446f234c8baa07, but this could change our builds as well. I was looking at current build logs, seeing if I could spot their Makefile flags being added to ours, but couldn't find it. Maybe this isn't used in this pmdk-convert build, which is only concerned with the conversion of pool format, and not the whole pmdk stack.