Comment 4 for bug 496784

Revision history for this message
In , Scott James Remnant (Canonical) (canonical-scott) wrote :

Notes from brief IRC discussion:

 - ply_console_t is intended to be "the console which has the active vt", but is being used in ways that really mean "plymouth's vt"

 - there isn't a race-free way to always know that the active vt is plymouth's vt

 - rename ply_console_t to ply_vt_t, the operations on it are all the things we want to do to plymouth's VT anyway (VT_PROCESS, set mode, etc.)

 - ply_vt_new (state->default_tty)

 - What about renderers that don't need a VT (x11?)

 - new terminal from vt - for the default case?

 - should ply_console remain just for get_active_vt and set_active_vt which can be done on /dev/tty0 (though they can be done on /dev/tty7 just as easily)