Comment 5 for bug 1983205

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote : Re: Import >= 8.1.6 to fix OPcache bug

Hi Kraut,

Thanks for driving that one.

I just uploaded PHP 8.1.7 to kinetic [1], which should fix the bug in the development release and unblock us to possibly start the SRU process to get this fixed in jammy.

Your PPA looks good. Would you like to provide a debdiff in this bug so we could use it in the SRU process?

Here is a few improvements it would be nice to apply to the package in your PPA before submitting the debdiff here:

- Could you change the version to "8.1.2-1ubuntu2.3"? I am driving another, unrelated, php SRU and I will need to change the version there myself (I will use "2.4" or merge my changes with yours before the upload if we manage to finish our works in a similar time frame).

- Could you extract your patch file directly from https://github.com/php/php-src/commit/f20e11cbe12057bddade6ff9a2ff9ea1bb6084c9 with `git format-patch`? Then you can keep all the headers in the patch file, as git format-patch prepares it. It contains useful information and will also help in the next point below.

- Could you fix the DEP3 headers? You can add them in the end of the file. The final patch would look similar to [3].

- Could you also reference this bug both in the changelog and in the DEP3 header? In this case, the changelog entry would look like "d/p/0046-Fix-Opcache-breaks-autoloading.patch: backport OPcache fix from 8.1.6 (LP: #1983205)".

- Finally, if you want to push the SRU forward, you would need to file the SRU template in this bug. you can do this by editing this bug description by filling the entries in [4]. You can also add a new section in the end such as "[Original message]" To keep the old description of this bug under it. In [5] you will find an example of this template being filed. Do note that the "[Test Plan]" section contains a complete guide on how someone could verify that the change fixes the bug. In our case, if finding such test/reproducer is not feasible, as we discussed before in this bug, you could say that one should run php with some setup you know will trigger the bug for N hours or days and verify that the error do not occur.

Once 8.1.7 migrates to kinetic, this SRU template is filled, and we have a debdiff attached to this bug, I will upload your changes on your behalf (i.e., sponsor your changes).

Do note that we are currently in a freeze for the 22.04.1. So we may need to wait until 22.04.1 is out so we can land your changes.

[1] https://launchpad.net/ubuntu/+source/php8.1/8.1.7-1ubuntu1
[2] https://dep-team.pages.debian.net/deps/dep3/
[3] https://git.launchpad.net/ubuntu/+source/php8.1/tree/debian/patches/0046-Update-gcc-func-attr-macro.patch?h=ubuntu/kinetic-devel
[4] https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template
[5] https://bugs.launchpad.net/ubuntu/+source/php8.1/+bug/1975626