On 11.03.2016 [18:06:10 -0000], Steve Langasek wrote: > +ifeq ($(WITH_UNIVERSE),yes) > +DH_OPTIONS+=$(addprefix -N,$(shell dh_listpackages | grep -v $(addprefix -e ,$(UNIVERSE_PACKAGES)))) > +else > +DH_OPTIONS+=$(addprefix -N,$(shell dh_listpackages | grep $(addprefix -e ,$(UNIVERSE_PACKAGES)))) > +endif > > debhelper also supports -p options to specify which packages it works > on, as opposed to -N to specify packages to exclude. Couldn't this be > written more succinctly as: > > ifeq ($(WITH_UNIVERSE),yes) > DH_OPTIONS+=$(addprefix -p,$(UNIVERSE_PACKAGES)) > else > DH_OPTIONS+=$(addprefix -N,$(UNIVERSE_PACKAGES)) > endif > > ?
Yes, probably! Sorry, I was basing my changes off the Trusty boost/boost-mpi split. I'll try to update to the above and provide a debdiff.
On 11.03.2016 [18:06:10 -0000], Steve Langasek wrote: UNIVERSE) ,yes) =$(addprefix -N,$(shell dh_listpackages | grep -v $(addprefix -e ,$(UNIVERSE_ PACKAGES) ))) =$(addprefix -N,$(shell dh_listpackages | grep $(addprefix -e ,$(UNIVERSE_ PACKAGES) ))) UNIVERSE) ,yes) =$(addprefix -p,$(UNIVERSE_ PACKAGES) ) =$(addprefix -N,$(UNIVERSE_ PACKAGES) )
> +ifeq ($(WITH_
> +DH_OPTIONS+
> +else
> +DH_OPTIONS+
> +endif
>
> debhelper also supports -p options to specify which packages it works
> on, as opposed to -N to specify packages to exclude. Couldn't this be
> written more succinctly as:
>
> ifeq ($(WITH_
> DH_OPTIONS+
> else
> DH_OPTIONS+
> endif
>
> ?
Yes, probably! Sorry, I was basing my changes off the Trusty
boost/boost-mpi split. I'll try to update to the above and provide a
debdiff.