phablet-test-run will fail if the python3 import prints something to std
Bug #1327325 reported by
Leo Arias
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| address-book-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| phablet-tools (Ubuntu) |
Fix Released
|
High
|
Dimitri John Ledkov | ||
| ubuntu-system-settings (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Currently, phablet-test-run tries to import the tests using python3 and if it fails, it falls back to py2.
The problem is that the check for py3 checks any output returned by the command. So even if it's not an import error, it will think that py3 failed.
This is affecting the address-book-app, which started logging a deprecation warning. The warning comes from the toolkit, so this might affect many other apps soon.
It would be better if instead of just checking the output, phablet-test-run checks if "ImportError" appears on the output.
Related branches
lp:~elopio/address-book-app/workaround1327325-warning_to_file
- PS Jenkins bot: Approve (continuous-integration)
- Renato Araujo Oliveira Filho (community): Approve
-
Diff: 14 lines (+4/-0)1 file modifiedtests/autopilot/address_book_app/__init__.py (+4/-0)
- PS Jenkins bot: Approve (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 3628 lines (+1367/-954)43 files modifieddebian/control (+1/-0)
src/imports/Common/CMakeLists.txt (+1/-0)
src/imports/Common/ContactDetailBase.qml (+0/-2)
src/imports/Common/ContactDetailGroupBase.qml (+1/-12)
src/imports/Common/ContactDetailItem.qml (+0/-15)
src/imports/Common/RemoveContactsDialog.qml (+77/-0)
src/imports/ContactEdit/CMakeLists.txt (+0/-1)
src/imports/ContactEdit/ContactDetailGroupWithTypeEditor.qml (+0/-3)
src/imports/ContactEdit/ContactDetailNameEditor.qml (+1/-0)
src/imports/ContactEdit/ContactDetailSyncTargetEditor.qml (+18/-7)
src/imports/ContactEdit/ContactDetailWithTypeEditor.qml (+2/-18)
src/imports/ContactEdit/ContactEditor.qml (+113/-58)
src/imports/ContactEdit/EditToolbar.qml (+0/-66)
src/imports/ContactEdit/TextInputDetail.qml (+56/-28)
src/imports/ContactList/CMakeLists.txt (+1/-0)
src/imports/ContactList/ContactListPage.qml (+117/-50)
src/imports/ContactList/PageWithBottomEdge.qml (+355/-0)
src/imports/ContactView/ContactDetailAvatarView.qml (+9/-2)
src/imports/ContactView/ContactDetailSyncTargetView.qml (+3/-0)
src/imports/ContactView/ContactView.qml (+12/-16)
src/imports/MainWindow.qml (+1/-5)
src/imports/Ubuntu/Contacts/ContactListView.qml (+2/-2)
src/imports/Ubuntu/Contacts/ContactSimpleListView.qml (+15/-5)
src/imports/Ubuntu/Contacts/MultipleSelectionListView.qml (+8/-50)
src/imports/Ubuntu/Contacts/OrganicView.qml (+0/-135)
tests/autopilot/address_book_app/__init__.py (+0/-8)
tests/autopilot/address_book_app/_errors.py (+21/-0)
tests/autopilot/address_book_app/emulators/__init__.py (+0/-6)
tests/autopilot/address_book_app/emulators/main_window.py (+0/-342)
tests/autopilot/address_book_app/pages/__init__.py (+25/-0)
tests/autopilot/address_book_app/pages/_common.py (+53/-0)
tests/autopilot/address_book_app/pages/_contact_editor.py (+272/-0)
tests/autopilot/address_book_app/pages/_contact_list_page.py (+70/-26)
tests/autopilot/address_book_app/pages/_contact_view.py (+28/-0)
tests/autopilot/address_book_app/tests/__init__.py (+11/-16)
tests/autopilot/address_book_app/tests/test_add_contact.py (+38/-36)
tests/autopilot/address_book_app/tests/test_contactlist.py (+1/-1)
tests/autopilot/address_book_app/tests/test_create_new_from_uri.py (+10/-8)
tests/autopilot/address_book_app/tests/test_custom_proxy_objects.py (+1/-3)
tests/autopilot/address_book_app/tests/test_delete_contact.py (+3/-8)
tests/autopilot/address_book_app/tests/test_edit_contact.py (+39/-23)
tests/autopilot/address_book_app/tests/test_multiple_pick_mode.py (+1/-1)
tests/autopilot/address_book_app/tests/test_single_pick_mode.py (+1/-1)
lp:~fginther/phablet-tools/fix-ptr-python3-import-check
- Dimitri John Ledkov: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 17 lines (+6/-2)1 file modifiedphablet-test-run (+6/-2)
lp:~elopio/ubuntu-system-settings/python3
- Sebastien Bacher (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 272 lines (+51/-38)9 files modifieddebian/control (+16/-15)
debian/rules (+2/-2)
tests/CMakeLists.txt (+2/-2)
tests/autopilot/setup.py (+7/-7)
tests/autopilot/ubuntu_system_settings/__init__.py (+7/-0)
tests/autopilot/ubuntu_system_settings/tests/test_about.py (+11/-6)
tests/autopilot/ubuntu_system_settings/tests/test_cellular.py (+3/-3)
tests/autopilot/ubuntu_system_settings/utils/i18n.py (+1/-1)
tests/test_code.py (+2/-2)
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-system-settings (Ubuntu): | |
| status: | New → Fix Released |
Revision history for this message
| Dimitri John Ledkov (xnox) wrote | #2 |
| Changed in phablet-tools (Ubuntu): | |
| assignee: | Francis Ginther (fginther) → Dimitri John Ledkov (xnox) |
Revision history for this message
| Dimitri John Ledkov (xnox) wrote | #3 |
| Changed in phablet-tools (Ubuntu): | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Leo Arias (elopio) wrote | #4 |
Revision history for this message
| Dimitri John Ledkov (xnox) wrote | #5 |
| Changed in phablet-tools (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in address-book-app (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-
---------------
ubuntu-
[ Andrea Cimitan ]
* Workaround for OSK input area (LP: #1334429)
[ Sebastien Bacher ]
* battery, draw the x axis labels (LP: #1289460)
[ Iain Lane ]
* [time-date] Ask for properties over D-Bus even when the object is
not considered valued (due to the service timing out), to cause it
to be activated.
[ Leo Arias ]
* Ported the autopilot package to python3. (LP: #1327325)
-- Ubuntu daily release <email address hidden> Fri, 11 Jul 2014 08:55:46 +0000