Comment 65 for bug 1657256

Christian, Robbie:

Thanks for taking the time to review the patch that I've submitted. I think that
the latest patch that Christian worked on covers and clean most of the observations made by Robbie
earlier in the bug and I can confirm that it doesn't modifies the original patch with any substantial changes to what I am proposing to fix via this bug.

I've 2 observations in regards to comment #64.

1) I can definitively work with upstream to the fix made in "fix-gcc7-compiler-errors.patch",
I will make a reference to this bug in order to keep all the further work done in upstream in sync with this bug.

2) I have performed testing on top of the PPA[0] and the results seems to work and confirm
the original results of the patch, that means:

a) The sysbench OLTP completes with 50,100 and 200 concurrent threads.
b) No further segfaults are being trapped on the machine for the mysqld process.

A detail on the tests performed:

root@niedbalski-artful:~# dpkg -l | grep percona
ii percona-galera-3 3.19-0ubuntu1 ppc64el Galera replication framework for Percona XtraDB Cluster
ii percona-xtrabackup 2.3.7-0ubuntu2 ppc64el Open source backup tool for InnoDB and XtraDB
ii percona-xtradb-cluster-5.6-dbg 5.6.34-26.19-0ubuntu4~ppa11 ppc64el Debugging package for Percona XtraDB Cluster
ii percona-xtradb-cluster-server 5.6.34-26.19-0ubuntu4~ppa11 all Percona XtraDB Cluster database server
ii percona-xtradb-cluster-server-5.6 5.6.34-26.19-0ubuntu4~ppa11 ppc64el Percona XtraDB Cluster database server binaries
ii percona-xtradb-cluster-source-5.6 5.6.34-26.19-0ubuntu4~ppa11 ppc64el Percona XtraDB Cluster 5.6 source

Version: '5.6.34-79.1-79.1' socket: '/var/run/mysqld/mysqld.sock' port: 3306 Percona XtraDB Cluster (GPL), Release 5.6.34-26.19.4c779b7, wsrep_26.19

~# sysbench --test=oltp --mysql-host=10.75.206.156 --mysql-user=test --mysql-db=dbtest --oltp-test-mode=complex --max-requests=0 --max-time=130 --num-threads=100 run
sysbench 0.4.12: multi-threaded system evaluation benchmark

No DB drivers specified, using mysql
Running the test with following options:
Number of threads: 100

Doing OLTP test.
Running mixed OLTP test
Using Special distribution (12 iterations, 1 pct of values are returned in 75 pct cases)
Using "BEGIN" for starting transactions
Using auto_inc on the id column
Threads started!
Time limit exceeded, exiting...
(last message repeated 99 times)
Done.

OLTP test statistics:
    queries performed:
        read: 5309948
        write: 1794076
        other: 719120
        total: 7823144
    transactions: 339838 (2613.49 per sec.)
    deadlocks: 39444 (303.34 per sec.)
    read/write requests: 7104024 (54632.84 per sec.)
    other operations: 719120 (5530.33 per sec.)

Test execution summary:
    total time: 130.0321s
    total number of events: 339838
    total time taken by event execution: 12996.6388
    per-request statistics:
         min: 2.65ms
         avg: 38.24ms
         max: 1348.23ms
         approx. 95 percentile: 99.35ms

Threads fairness:
    events (avg/stddev): 3398.3800/48.54
    execution time (avg/stddev): 129.9664/0.01

---

@cpaelzer, Please let me know if there is any other task that needs to be performed on my side in order to get this merged/and start the SRU process for the other series?

Thanks in advance for your comments.