Comment 1 for bug 1824762

Revision history for this message
Trent Lloyd (lathiat) wrote :

Attaching patch for the issue.

The way the upstream percona-toolkit repository works is they have these perl modules that are statically "compiled in" to the various tool perl scripts, with both the source libraries and that resulting static tool committed to git.

They do not always update every tool when changes are made to those modules. So if you rebuild every tool, even from the same source as the release, you will get unrelated changes to the actual fix.

The source of the package (as released) does not contain the libraries (lib/**) or the tests (t/**) so these are not included in the package patch, in contrast to the upstream git diff.

I fixed all occurrences of the problem in all tools, but only tested pt-heartbeat and pt-query-digest. It is difficult to accurately test all of the tools, however, pretty much all of the tools were completely broken in basic functionality by the lack of this fix, and the change is an exact copy of the upstream fix.

The changed tools are:
pt-diskstats
pt-fk-error-logger
pt-heartbeat
pt-index-usage
pt-kill
pt-online-schema-change
pt-query-digest
pt-slave-delay
pt-slave-find
pt-table-checksum
pt-table-sync
pt-table-usage
pt-upgrade