Comment 2 for bug 712938

Revision history for this message
Bryce Harrington (bryce) wrote :

Hi Mahyuddin, I have a few questions.

I notice that this adds a patch 04_ipv6_localhost.patch which looks fine but should be mentioned in the changelog.
Also, I see this updates three patches, and you should mention this in the changelog as well (if there are no functional changes to the patches, you can simply say "refreshed for quilt" or some such.) Also, I see your name is added as the Author of all four patches - unless you actually wrote the patches originally it might be better to omit your name from them.

Many of the items in the changelog sound like they were from Debian; is it possible you are basing your package update on a snapshot of a Debian git tree? If so, you should make mention of this fact, as it will make future merges with Debian more straightforward.