On Fri, Mar 26, 2010 at 01:40:37PM -0000, Neil Perry wrote:
> @ Phillip Susi - I have reviewed you're patch, which seems to build fine
> and fix the issue. Could you please post this upstream.
I commented separately on issues with the patch, with a more detailed
review (does the Ubuntu Review Team review code, or just the form? The
latter seems more useful). I agree that it should be forwarded upstream
once those issues are resolved, but I intend to apply it or a variant of
it to Ubuntu without waiting for it to get through upstream review,
since this is critical for Lucid.
On Fri, Mar 26, 2010 at 01:40:37PM -0000, Neil Perry wrote:
> @ Phillip Susi - I have reviewed you're patch, which seems to build fine
> and fix the issue. Could you please post this upstream.
I commented separately on issues with the patch, with a more detailed
review (does the Ubuntu Review Team review code, or just the form? The
latter seems more useful). I agree that it should be forwarded upstream
once those issues are resolved, but I intend to apply it or a variant of
it to Ubuntu without waiting for it to get through upstream review,
since this is critical for Lucid.