Comment 30 for bug 1473903

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Don't both device names actually work fine though? I couldn't find any blocking issue to leaving both in place, since they don't seem to interfere with any operation of the system. This would certainly constitute the least-intrusive change, on account that there would be no change required.

Otherwise, there doesn't seem to be a straightforward way to fix this. We basically have two not great options to contend with (unless someone else can think of another):

1) Patch parted to write -part partitions instead of -p.
This is fine for the installed system, but means we'd need to revert SRUs already done for multipath-tools in the installer -- where we expect to see -p partitions always, and rewrite them to -part at the end (since there will be just kpartx on the installed system), modify partman-multipath to pick up all partitions and make them -part. There remains the issue of rewriting fstab later on, when comes the time to migrate to multipath 0.5.0 (which changes the partition names in other ways too, so unavoidable).

2) Fix kpartx rules either by disabling them or making them use -p only.
This would fix the installed system (since parted creates p partitions itself) and detected partitions on drives at boot would show up correctly, but we'd need to do other SRU changes to installer bits to not rewrite /etc/fstab to use -part as a partition separator. This is apparently a simpler change, but means we also need to deal with changing fstab on upgrade for those who use -part, which makes it dangerous and very intrusive.

I'd love to get some guidance on this, but I'm thinking not changing anything for now is the best option; although if there is any effect in having both devices show up and we need to stop it, then 1) would be best.