Comment 3 for bug 2070081

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the patch, Zixing Liu.

I'd like to ask you adjust a few things before we proceed with the upload:

1) Since you're adding a delta, you also need to run update-maintainer in order to have the Maintainer field set to Ubuntu Developers instead of the regular Debian maintainer.

2) You're also reorganizing the definitions of the compiler flags. Could you please mention this in the changelog entry?

3) While the CMAKE_BUILD_TYPE change looks sensible to me, it would be great if you could provide a PPA where the modified package builds properly.

I will remove ubuntu-sponsors from the notification list for now. Please re-add it when the package is ready to be reviewed again.

Thanks!