Comment 6 for bug 509078

Revision history for this message
Thierry Carrez (ttx) wrote :

Minor remarks:
 * To ease the review, you should provide a debdiff from the Debian version to the Ubuntu version (here, the output of "debdiff openvpn_2.1.0-1.dsc openvpn_2.1.0-1ubuntu1.dsc").
 * Changelog should list all remaining delta with Debian, so I changed it to read:

  Merge from debian testing (LP: #509078), remaining changes:
    + debian/openvpn.init.d:
      - Do not use start-stop-daemon and use < /dev/null to avoid blocking boot
      - Show per-VPN result messages
      - Add "--script-security 2" by default for backwards compatibility
    + debian/control: Add lsb-base >= 3.2-14 to allow status_of_proc()

Otherwise looks good, uploaded, thanks !