Rejecting for now, based on the diff, until someone explains to me why the upstream commit adds the same code block to two files (s3_clnt.c and s23_clnt.c), but the Ubuntu patch only swaps the get_version call to get_client_version in one of them (s23_clnt.c). This feels wrong to me, but maybe there's a valid reason for it?
Rejecting for now, based on the diff, until someone explains to me why the upstream commit adds the same code block to two files (s3_clnt.c and s23_clnt.c), but the Ubuntu patch only swaps the get_version call to get_client_version in one of them (s23_clnt.c). This feels wrong to me, but maybe there's a valid reason for it?