Comment 36 for bug 1971094

Hi Sudip and Dave,

Thanks for the great SRU template and contributing a patch!

I'll re-upload with minor, but relevant changes (please review), and accept for Jammy.

The modified code is either already patched or no longer exists/has changed in Mantic.

Changes:

- Setting the bug importance to High per [1].

- d/changelog: include filenames to describe the changes

- d/p/*.patch:

  - `Origin:` should be `backport` as there are changes from upstream; see DEP-3 [2]:
    ```"backport" (... upstream patch that had to be modified ...)```

  - `Author:` added, considering the above, as some changes are yours, for credit.

  - For clarity, this could be done in 2 separate patches: one from upstream and
    another one with your fixes (since upstream doesn't maintain a stable branch
    where such changes could be submitted to, apparently; and linked downstream).
    But this is preference/style, not a requirement.

  - The patch filename could use the `lpNUMBER-title.patch` format, with `title`
    either coming from the upstream patch (if there's one, like this case) or
    sometimes adding more specifics of the fix (e.g., as you did in `Description`).
    This, too, is preference/style, not a requirement, but it does help over time.

cheers,

[1] https://wiki.ubuntu.com/Bugs/Importance
[2] https://dep-team.pages.debian.net/deps/dep3/

$ diff -U0 old.debdiff new.debdiff
--- old.debdiff 2024-03-04 12:51:10.000000000 +0000
+++ new.debdiff 2024-03-04 19:39:48.150692799 +0000
@@ -7 +7 @@
-+ * Fix crash on startup. (LP: #1971094)
++ * d/p/0009-Fix-runtime.patch: Fix crash on startup. (LP: #1971094)
@@ -32,2 +32,2 @@
-+
-+Origin: upstream, https://github.com/OpenShot/openshot-qt/commit/cd69f2ad8d10c26b20eb9ae46bcc288f3c322b85
++Author: Sudip Mukherjee <email address hidden>
++Origin: backport, https://github.com/OpenShot/openshot-qt/commit/cd69f2ad8d10c26b20eb9ae46bcc288f3c322b85
@@ -35 +35 @@
-+Last-Update: 2024-02-16
++Last-Update: 2024-03-04