Comment 42 for bug 646157

Revision history for this message
In , julien2412 (serval2412-6) wrote :

On pc Debian x86-64 with master sources updated today, I could reproduce tdf#65837 (which is very quick to try)

Reverting https://cgit.freedesktop.org/libreoffice/core/commit/?id=1363fe2fa6849aa1ac678ea444c58a82d417eb47 allows to call AdjustRowHeight functions at the Excel import and tdf#65837 was ok (I must admit I haven't retested tdf#34552 before or after reverting this commit)

Here are the lines:
+#if 0
+ // Excel documents look much better without this call; better in the
+ // sense that the row heights are identical to the original heights in
+ // Excel.
         if (pD->IsAdjustHeightEnabled())
             AdjustRowHeight();
-
+#endif
(see http://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/read.cxx#1298)

Eike/Katarina/Markus: any thought?
1) Should we let this as it is for perf (and so wontfix) ?
2) Should we let this block (or remove it since it's "#if 0") and call AdjustRowHeight at a specific location in order to not decrease too much perf?
3) Should we remove the if/endif (+associated comment) and let the 2 instructions? (because we know that perf should be ok now)
4) other?

(since Kohei removed himself from https://wiki.documentfoundation.org/FindTheExpert, I didn't want to annoy him with this).