Comment 30 for bug 231953

Revision history for this message
In , Nicciglen (nicciglen) wrote :

> in autodetected a11y HC mode, pull background color from theme

Thanks for looking into fixing this bug.

HOWEVER please NOTE: When a11y HC mode is detected, *both* the text colour and background colour need to be pulled from underlying OS theme.

> - dark theme default to high contrast
> - as per fdo#35365, having a dark document background is
> inconvenient for non-a11y endusers
> - a11y standard require the (rather ugly) background for a11y
> - thus, when "automatically detect high contract mode of operating system" in > Tools->Options->a11y is enabled, use the dark document background by
> default, otherwise use a white default

From the code commit comment, I'm not sure if the requirements for this a11y feature have been fully understood.

A high-contrast theme - doesn't necessarily need to have a dark background. It can have any background colour or text colour combination that a partially sighted user finds easier to see. It could be say bright orange background with black text.

The point is that Windows (and I'm sure Linux) can have several high-contrast themes, where the background colour can be anything and the foreground colour can be anything that is beneficial for the partially sighted user.

In summary, as long as you are pulling *both* the background and foreground colours from the OS a11y theme, when an OS high-contrast theme is detected - then you are restoring the functionality that LibreOffice / Open Office have had for a very long time.

(PS. Yes, high-contrast themes may look ugly to non-a11y users, but they are a life-changing enabler for people with various vision problems)