Comment on attachment 229268 Patch for the crash
> long /*int*/ originalAuth = WebKitGTK.soup_session_get_feature (session, WebKitGTK.webkit_soup_auth_dialog_get_type ()); >- WebKitGTK.soup_session_feature_detach (originalAuth, session); >+ if (originalAuth != 0) { >+ WebKitGTK.soup_session_feature_detach (originalAuth, session); >+ } > OS.g_signal_connect (session, WebKitGTK.authenticate, Proc5.getAddress (), webView); >- WebKitGTK.soup_session_feature_attach (originalAuth, session); >+ if (originalAuth != 0) { >+ WebKitGTK.soup_session_feature_attach (originalAuth, session); >+ }
FWIW, the lookup/detach/attach code there is completely unnecessary anyway... The only line here that actually does anything is the g_signal_connect() line.
Comment on attachment 229268
Patch for the crash
> long /*int*/ originalAuth = WebKitGTK. soup_session_ get_feature (session, WebKitGTK. webkit_ soup_auth_ dialog_ get_type ()); soup_session_ feature_ detach (originalAuth, session); soup_session_ feature_ detach (originalAuth, session); authenticate, Proc5.getAddress (), webView); soup_session_ feature_ attach (originalAuth, session); soup_session_ feature_ attach (originalAuth, session);
>- WebKitGTK.
>+ if (originalAuth != 0) {
>+ WebKitGTK.
>+ }
> OS.g_signal_connect (session, WebKitGTK.
>- WebKitGTK.
>+ if (originalAuth != 0) {
>+ WebKitGTK.
>+ }
FWIW, the lookup/ detach/ attach code there is completely unnecessary anyway... The only line here that actually does anything is the g_signal_connect() line.