Ubuntu
opengcs package

  1. Bug #1912691
  2. Comment #11

Comment 11 for bug 1912691

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Lucas.

I reviewed the patches and they look fine. A very small nit: you're using your @debian.org email in the Groovy changelog.

Other than that, all 3 patches LGTM. I did build all 3 packages in a local sbuild, and the builds succeeded.

A few comments about the SRU template:

- In the "Test Plan" section, s/caught/catch/.

- In the "Where problems could occur" section, this sentence seems strange: "We are replacing a system call which would require cgo with a constant." Just pointing it out in case you want to clarify it.

Thanks.