Comment 10 for bug 2003668

Revision history for this message
Simon Chopin (schopin) wrote :

Many thanks Holger for the pkg-config snippet!

Alexandre, I'll trust you on the watchfile, since my knowledge of uscan arcane is very thin.

I uploaded the package as is, as it's in a fairly good shape and we're cutting it pretty close to the release. However, I do have following remarks that should be addressed in the next upload *after the release*:

* issue: Please add the pubkey used to sign the releases, Lintian complains (fairly) about it:
  E: openssl-pkcs11-sign-provider source: debian-watch-file-pubkey-file-is-missing [debian/watch]

* suggestion: d/copyright: if you add a stand-alone License: Apache-2 paragraph at the end of the file, you can avoid repeating the full text of the license. That's how the MIT license is handled in this random example:
  https://salsa.debian.org/debian/weechat-matrix/-/blob/master/debian/copyright

* suggestion: d/docs: openssl-ock.cnf.sample should probably be in d/examples (see dh_installexamples)

* nitpick: d/rules: I don't think the makeshlibs override is still necessary now that we fixed the install path?