| 2020-11-02 19:48:07 |
Ian May |
bug |
|
|
added bug |
| 2020-11-10 15:55:02 |
Ian May |
description |
[Impact]
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:28,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:73:20: error: field ‘va_atime’ has incomplete type
73 | struct timeval va_atime;
| ^~~~~~~~
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:74:20: error: field ‘va_mtime’ has incomplete type
74 | struct timeval va_mtime;
| ^~~~~~~~
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:75:20: error: field ‘va_ctime’ has incomplete type
75 | struct timeval va_ctime;
| ^~~~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs_osi.h:440,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/rx/rx_clock.h:46,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/rx/rx.h:57,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:30,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_machdep.h:80:15: error: unknown type name ‘time_t’
80 | static inline time_t osi_Time(void) {
| ^~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:48,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs.h:310:5: error: unknown type name ‘time_t’
310 | time_t timeout; /* data expire time, if non-zero */
| ^~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:57,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs_prototypes.h:957:58: error: unknown type name ‘time_t’; did you mean ‘ktime_t’?
957 | extern int afs_ExtractTokensForPioctl(struct tokenJar *, time_t,
| ^~~~~~
| ktime_t
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h: In function ‘gettimeofday’:
/var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:102:35: error: dereferencing pointer to incomplete type ‘struct timeval’
102 | {if (tp == NULL) return -1; tp->tv_sec = osi_Time(); tp->tv_usec = 0; return 0;}
| ^~
[Test Case]
$ sudo apt install openafs-modules-dkms
[Fix]
Adding #if directives and changes from timeval to timespec where needed.
[Regression Potential]
The source code for the 5.4 kernel remains the same, so there is no regression potential. The new changes are all conditionals and they are all applied to the 5.8 kernel. |
[Impact]
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:28,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:73:20: error: field ‘va_atime’ has incomplete type
73 | struct timeval va_atime;
| ^~~~~~~~
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:74:20: error: field ‘va_mtime’ has incomplete type
74 | struct timeval va_mtime;
| ^~~~~~~~
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:75:20: error: field ‘va_ctime’ has incomplete type
75 | struct timeval va_ctime;
| ^~~~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs_osi.h:440,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/rx/rx_clock.h:46,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/rx/rx.h:57,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:30,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_machdep.h:80:15: error: unknown type name ‘time_t’
80 | static inline time_t osi_Time(void) {
| ^~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:48,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs.h:310:5: error: unknown type name ‘time_t’
310 | time_t timeout; /* data expire time, if non-zero */
| ^~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:57,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs_prototypes.h:957:58: error: unknown type name ‘time_t’; did you mean ‘ktime_t’?
957 | extern int afs_ExtractTokensForPioctl(struct tokenJar *, time_t,
| ^~~~~~
| ktime_t
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h: In function ‘gettimeofday’:
/var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:102:35: error: dereferencing pointer to incomplete type ‘struct timeval’
102 | {if (tp == NULL) return -1; tp->tv_sec = osi_Time(); tp->tv_usec = 0; return 0;}
| ^~
[Test Case]
$ sudo apt install openafs-modules-dkms
[Fix]
Adding changes from timeval to timespec where needed and changes from 5.8 openafs to replace kernel_setsockopt.
[Regression Potential]
Medium to low, changes are wrapped in #if directives. Confirmed module installs and loads on both 5.4 and 5.8. The number of changes does create some concern for regression. |
|
| 2020-11-10 16:28:06 |
Ian May |
attachment added |
|
openafs-linux-5.8-fixes.debdiff https://bugs.launchpad.net/ubuntu/+source/openafs/+bug/1902581/+attachment/5433048/+files/openafs-linux-5.8-fixes.debdiff |
|
| 2020-11-10 16:29:15 |
Ian May |
nominated for series |
|
Ubuntu Focal |
|
| 2020-11-10 16:29:15 |
Ian May |
bug task added |
|
openafs (Ubuntu Focal) |
|
| 2020-11-10 16:53:17 |
Ian May |
openafs (Ubuntu Focal): status |
New |
In Progress |
|
| 2020-11-10 16:53:33 |
Ian May |
openafs (Ubuntu): status |
New |
Invalid |
|
| 2020-11-10 16:53:41 |
Ian May |
openafs (Ubuntu Focal): assignee |
|
Ian (ian-may) |
|
| 2020-11-10 17:48:45 |
Ian May |
description |
[Impact]
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:28,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:73:20: error: field ‘va_atime’ has incomplete type
73 | struct timeval va_atime;
| ^~~~~~~~
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:74:20: error: field ‘va_mtime’ has incomplete type
74 | struct timeval va_mtime;
| ^~~~~~~~
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:75:20: error: field ‘va_ctime’ has incomplete type
75 | struct timeval va_ctime;
| ^~~~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs_osi.h:440,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/rx/rx_clock.h:46,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/rx/rx.h:57,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:30,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_machdep.h:80:15: error: unknown type name ‘time_t’
80 | static inline time_t osi_Time(void) {
| ^~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:48,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs.h:310:5: error: unknown type name ‘time_t’
310 | time_t timeout; /* data expire time, if non-zero */
| ^~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:57,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs_prototypes.h:957:58: error: unknown type name ‘time_t’; did you mean ‘ktime_t’?
957 | extern int afs_ExtractTokensForPioctl(struct tokenJar *, time_t,
| ^~~~~~
| ktime_t
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h: In function ‘gettimeofday’:
/var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:102:35: error: dereferencing pointer to incomplete type ‘struct timeval’
102 | {if (tp == NULL) return -1; tp->tv_sec = osi_Time(); tp->tv_usec = 0; return 0;}
| ^~
[Test Case]
$ sudo apt install openafs-modules-dkms
[Fix]
Adding changes from timeval to timespec where needed and changes from 5.8 openafs to replace kernel_setsockopt.
[Regression Potential]
Medium to low, changes are wrapped in #if directives. Confirmed module installs and loads on both 5.4 and 5.8. The number of changes does create some concern for regression. |
[Impact]
openafs-modules-dkms failing to build on linux-hwe-5.8 kernel
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:28,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:73:20: error: field ‘va_atime’ has incomplete type
73 | struct timeval va_atime;
| ^~~~~~~~
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:74:20: error: field ‘va_mtime’ has incomplete type
74 | struct timeval va_mtime;
| ^~~~~~~~
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:75:20: error: field ‘va_ctime’ has incomplete type
75 | struct timeval va_ctime;
| ^~~~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs_osi.h:440,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/rx/rx_clock.h:46,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/rx/rx.h:57,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:30,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_machdep.h:80:15: error: unknown type name ‘time_t’
80 | static inline time_t osi_Time(void) {
| ^~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:48,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs.h:310:5: error: unknown type name ‘time_t’
310 | time_t timeout; /* data expire time, if non-zero */
| ^~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:57,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs_prototypes.h:957:58: error: unknown type name ‘time_t’; did you mean ‘ktime_t’?
957 | extern int afs_ExtractTokensForPioctl(struct tokenJar *, time_t,
| ^~~~~~
| ktime_t
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h: In function ‘gettimeofday’:
/var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:102:35: error: dereferencing pointer to incomplete type ‘struct timeval’
102 | {if (tp == NULL) return -1; tp->tv_sec = osi_Time(); tp->tv_usec = 0; return 0;}
| ^~
[Test Case]
$ sudo apt install openafs-modules-dkms
[Fix]
Adding changes from timeval to timespec where needed and changes from 5.8 openafs to replace kernel_setsockopt.
[Regression Potential]
Medium to low, changes are wrapped in #if directives. Confirmed module installs and loads on both 5.4 and 5.8. The number of changes does create some concern for regression. |
|
| 2020-11-10 17:59:32 |
Ian May |
attachment added |
|
make.log https://bugs.launchpad.net/ubuntu/+source/openafs/+bug/1902581/+attachment/5433060/+files/make.log |
|
| 2020-11-10 18:02:14 |
Ian May |
description |
[Impact]
openafs-modules-dkms failing to build on linux-hwe-5.8 kernel
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:28,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:73:20: error: field ‘va_atime’ has incomplete type
73 | struct timeval va_atime;
| ^~~~~~~~
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:74:20: error: field ‘va_mtime’ has incomplete type
74 | struct timeval va_mtime;
| ^~~~~~~~
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_vfs.h:75:20: error: field ‘va_ctime’ has incomplete type
75 | struct timeval va_ctime;
| ^~~~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs_osi.h:440,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/rx/rx_clock.h:46,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/rx/rx.h:57,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:30,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_machdep.h:80:15: error: unknown type name ‘time_t’
80 | static inline time_t osi_Time(void) {
| ^~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:48,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs.h:310:5: error: unknown type name ‘time_t’
310 | time_t timeout; /* data expire time, if non-zero */
| ^~~~~~
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afsincludes.h:57,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:31,
from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/afs_prototypes.h:957:58: error: unknown type name ‘time_t’; did you mean ‘ktime_t’?
957 | extern int afs_ExtractTokensForPioctl(struct tokenJar *, time_t,
| ^~~~~~
| ktime_t
In file included from /var/lib/dkms/openafs/1.8.4pre1/build/src/libafs/MODLOAD-5.8.0-25-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h: In function ‘gettimeofday’:
/var/lib/dkms/openafs/1.8.4pre1/build/src/crypto/hcrypto/kernel/config.h:102:35: error: dereferencing pointer to incomplete type ‘struct timeval’
102 | {if (tp == NULL) return -1; tp->tv_sec = osi_Time(); tp->tv_usec = 0; return 0;}
| ^~
[Test Case]
$ sudo apt install openafs-modules-dkms
[Fix]
Adding changes from timeval to timespec where needed and changes from 5.8 openafs to replace kernel_setsockopt.
[Regression Potential]
Medium to low, changes are wrapped in #if directives. Confirmed module installs and loads on both 5.4 and 5.8. The number of changes does create some concern for regression. |
[Impact]
openafs-modules-dkms failing to build on linux-hwe-5.8 kernel(see attached make.log for details)
[Test Case]
$ sudo apt install openafs-modules-dkms
[Fix]
Adding all necessary changes from groovy 5.8 dkms module without affecting 5.4 code.
[Regression Potential]
Medium to low, changes are wrapped in #if directives. Confirmed module installs and loads on both 5.4 and 5.8. The number of changes does create some concern for regression. |
|
| 2020-11-17 23:32:03 |
Ian May |
attachment removed |
openafs-linux-5.8-fixes.debdiff https://bugs.launchpad.net/ubuntu/+source/openafs/+bug/1902581/+attachment/5433048/+files/openafs-linux-5.8-fixes.debdiff |
|
|
| 2020-11-17 23:32:31 |
Ian May |
attachment added |
|
openafs-linux-5.8-fixes.debdiff https://bugs.launchpad.net/ubuntu/+source/openafs/+bug/1902581/+attachment/5435272/+files/openafs-linux-5.8-fixes.debdiff |
|
| 2020-12-07 17:23:59 |
Łukasz Zemczak |
openafs (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2020-12-07 17:24:01 |
Łukasz Zemczak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2020-12-07 17:24:03 |
Łukasz Zemczak |
bug |
|
|
added subscriber SRU Verification |
| 2020-12-07 17:24:06 |
Łukasz Zemczak |
tags |
|
verification-needed verification-needed-focal |
|
| 2020-12-14 17:00:12 |
Kleber Sacilotto de Souza |
tags |
verification-needed verification-needed-focal |
verification-done-focal verification-needed |
|
| 2020-12-14 18:39:42 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2020-12-14 18:49:46 |
Launchpad Janitor |
openafs (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
