Comment 4 for bug 1638769

Revision history for this message
James Henstridge (jamesh) wrote :

Is this actually working as intended?

Looking at the changes in the latest package it only affects the GetAccounts() call, so we don't get back the additional account metadata from the RequestAccess() method, or the AccountChanged signal.

Further more, the extra "services" return value from GetAccounts() seems to be empty here:

    $ gdbus call --session --dest com.ubuntu.OnlineAccounts.Manager --object-path /com/ubuntu/OnlineAccounts/Manager --method com.ubuntu.OnlineAccounts.Manager.GetAccounts {}
    ([(uint32 8, {'authMethod': <3>, 'displayName': <'james@localhost:8888/owncloud'>, 'serviceId': <'storage-provider-owncloud'>, 'settings/host': <'http://localhost:8888/owncloud'>}), ...], @aa{sv} [])

Was there any reason not to just ship this extra account information as part of the existing a{sv} dict used by all the existing methods?