Comment 1 for bug 1206941

Revision history for this message
Tony Espy (awe) wrote :

So is this is a pretty obvious, function-didn't get implemented type of bug.

The rilmodem's sim modules doesn't define a function for ofono_sim_driver.(*query_pin_retries).

On the RIL side, there's no RIL message that can be used to query the various PIN retry counts. Instead, the RIL PIN requests all return the current retry value for the specified PIN. Unfortunately, the ofono DBus API doesn't return a PIN retries count when EnterPin is called.

This is definitely a case of RIL/ofono API mismatch...

So, the only possible way I can see to fix is:

1. When a SIM PIN required condition is detected, rilmodem's internal 'pin_retries' is set to 3.
2. If rilmodem's (*send_passwd) function is called, the returned retry value is used to update the internal 'pin_retries' count.
3. If a (*change_passwd) operation succeeds, reset 'pin_retries' to 3

The same technique could be applied to "puk" as well.

I'd appreciate a quick comment as to whether or not this missing feature impacts the current UI design? Can the UI be implemented by just examining the PIN/PUK related properties?