Comment 6 for bug 1613469

Revision history for this message
Michael Terry (mterry) wrote :

Using ofono-phonesim and scripting the manual interactions (like starting a call, restarting ofono) all seems like perfect a candidate for autopkgtest (rather than a unit test, where you may not want to mess up your dev system).

The custom patches to ofono-qt are all the more reason to migrate to libqofono. We have other code that is using libqofono and may benefit from those patches, rather than just telephony-service.

Since telephony-ofono is the only rdepend of ofono-qt, moving it into the t-ofono and dropping ofono-qt from the archive is a reasonable way to avoid other packages depending on it once we 'bless' it.

But... that probably would make the security team's life a little harder if/when there's a security patch. They may not know we have an internal copy in t-ofono, but they would notice an archive package.

Normally yes, we block needlessly duplicated libraries going into main if we can. It's an update and security burden (and a source of bugs when apps don't work the same because they have different library behaviors).

I'd be fine with promoting this in main on a temporary basis, if you folks have a milestoned bug/plan to move everything over to libqofono. It will be good to stop investing custom patches into a dead-end library.

But no tests as well? Is there not even a subset of tests that don't require manual interaction that we can run, under phonesim as necessary? Not having automated tests seems like a disaster waiting to happen, and we have better standards in Touch than that.