nvidia-dkms-* FTBS with linux 6.8

[Paolo Pisati]

[Impact]

...
In file included from /var/lib/dkms/nvidia/470.223.02/build/nvidia-drm/nvidia-drm-drv.c:60:
/var/lib/dkms/nvidia/470.223.02/build/nvidia-drm/nvidia-drm-drv.c:748:40: error: ‘DRM_UNLOCKED’ undeclared here (not in a function); did you mean ‘VM_LOCKED’?
  748 | DRM_RENDER_ALLOW|DRM_UNLOCKED),
      | ^~~~~~~~~~~~
...

[Fix]

Apply the attached debdiff.

[How to test]

Install (and rebuild) the patched package.

[Regression potential]

Two patches, none originating from NVidia and both touching locking: there's definitely regression potential here, hence i'm proposing this upload *only* for Noble and as a way to move forward (and not stall) until NVidia drops a new version.

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-470-server - 470.223.02-0ubuntu2

---------------
nvidia-graphics-drivers-470-server (470.223.02-0ubuntu2) noble; urgency=medium

  * debian/dkms_nvidia/patches/buildfix_kernel_6.8-nv_drm_ioctls-DRM_UNLOCKED-is-now-the-default-behavi.patch,
    debian/dkms_nvidia/patches/buildfix_kernel_6.8-gpl-pfn_valid.patch:
    - Fix build with Linux 6.8 (LP: #2052420)

 -- Paolo Pisati <email address hidden> Mon, 05 Feb 2024 08:33:36 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-545 - 545.29.06-0ubuntu5

---------------
nvidia-graphics-drivers-545 (545.29.06-0ubuntu5) noble; urgency=medium

  * debian/dkms_nvidia/patches/buildfix_kernel_6.8-nv_drm_ioctls-DRM_UNLOCKED-is-now-the-default-behavi.patch,
    debian/dkms_nvidia/patches/buildfix_kernel_6.8-gpl-pfn_valid.patch:
    - Fix build with Linux 6.8 (LP: #2052420)

 -- Paolo Pisati <email address hidden> Mon, 05 Feb 2024 08:33:36 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-470 - 470.223.02-0ubuntu2

---------------
nvidia-graphics-drivers-470 (470.223.02-0ubuntu2) noble; urgency=medium

  * debian/dkms_nvidia/patches/buildfix_kernel_6.8-nv_drm_ioctls-DRM_UNLOCKED-is-now-the-default-behavi.patch,
    debian/dkms_nvidia/patches/buildfix_kernel_6.8-gpl-pfn_valid.patch:
    - Fix build with Linux 6.8 (LP: #2052420)

 -- Paolo Pisati <email address hidden> Mon, 05 Feb 2024 08:33:36 +0000

[Dylan Borg (borgdylan)]

This issue affects the Linux 6.7 series as well as from 6.7.3. I have met this issue on mantic as I was trying to install the vanilla 6.7.3 kernel on a system with the nvidia 545 driver.

[Ionut Nechita (ionut-n2001)]

Using kernel 6.8.0-rc5 this is working correctly with nvidia-driver-545=545.29.06-0ubuntu5.

dpkg -l | grep nvidia
ii libnvidia-cfg1-545:amd64 545.29.06-0ubuntu5 amd64 NVIDIA binary OpenGL/GLX configuration library
ii libnvidia-common-545 545.29.06-0ubuntu5 all Shared files used by the NVIDIA libraries
ii libnvidia-compute-545:amd64 545.29.06-0ubuntu5 amd64 NVIDIA libcompute package
ii libnvidia-compute-545:i386 545.29.06-0ubuntu5 i386 NVIDIA libcompute package
ii libnvidia-decode-545:amd64 545.29.06-0ubuntu5 amd64 NVIDIA Video Decoding runtime libraries
ii libnvidia-decode-545:i386 545.29.06-0ubuntu5 i386 NVIDIA Video Decoding runtime libraries
ii libnvidia-encode-545:amd64 545.29.06-0ubuntu5 amd64 NVENC Video Encoding runtime library
ii libnvidia-encode-545:i386 545.29.06-0ubuntu5 i386 NVENC Video Encoding runtime library
ii libnvidia-extra-545:amd64 545.29.06-0ubuntu5 amd64 Extra libraries for the NVIDIA driver
ii libnvidia-fbc1-545:amd64 545.29.06-0ubuntu5 amd64 NVIDIA OpenGL-based Framebuffer Capture runtime library
ii libnvidia-fbc1-545:i386 545.29.06-0ubuntu5 i386 NVIDIA OpenGL-based Framebuffer Capture runtime library
ii libnvidia-gl-545:amd64 545.29.06-0ubuntu5 amd64 NVIDIA OpenGL/GLX/EGL/GLES GLVND libraries and Vulkan ICD
ii libnvidia-gl-545:i386 545.29.06-0ubuntu5 i386 NVIDIA OpenGL/GLX/EGL/GLES GLVND libraries and Vulkan ICD
ii nvidia-compute-utils-545 545.29.06-0ubuntu5 amd64 NVIDIA compute utilities
ii nvidia-dkms-545 545.29.06-0ubuntu5 amd64 NVIDIA DKMS package
ii nvidia-driver-545 545.29.06-0ubuntu5 amd64 NVIDIA driver metapackage
ii nvidia-firmware-545-545.29.06 545.29.06-0ubuntu5 amd64 Firmware files used by the kernel module
ii nvidia-headless-no-dkms-545 545.29.06-0ubuntu5 amd64 NVIDIA headless metapackage - no DKMS
ii nvidia-kernel-common-545 545.29.06-0ubuntu5 amd64 Shared files used with the kernel module
ii nvidia-kernel-source-545 545.29.06-0ubuntu5 amd64 NVIDIA kernel source package
ii nvidia-prime 0.8.17.2 all Tools to enable NVIDIA's Prime
ii nvidia-settings 510.47.03-0ubuntu...

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-535-server - 535.161.07-0ubuntu2

---------------
nvidia-graphics-drivers-535-server (535.161.07-0ubuntu2) noble; urgency=medium

  * remove debian/dkms_nvidia/patches/buildfix_kernel_6.8-nv_drm_ioctls-DRM_UNLOCKED-is-now-the-default-behavi.patch
  * remove debian/dkms_nvidia/patches/buildfix_kernel_6.8-gpl-pfn_valid.patch

 -- Kuba Pawlak <email address hidden> Thu, 29 Feb 2024 18:54:31 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-535 - 535.161.07-0ubuntu3

---------------
nvidia-graphics-drivers-535 (535.161.07-0ubuntu3) noble; urgency=medium

  * Disable 6.8 buildfix patches
    -debian/dkms_nvidia/patches/buildfix_kernel_6.8-nv_drm_ioctls-DRM_UNLOCKED-is-now-the-default-behavi.patch
    -debian/dkms_nvidia/patches/buildfix_kernel_6.8-gpl-pfn_valid.patch

 -- Ian May <email address hidden> Wed, 28 Feb 2024 16:50:45 -0600

[Ionut Nechita (ionut-n2001)]

Hi,

I have question,
Is possible to add this patches:
PATCH[0]="disable_fstack-clash-protection_fcf-protection.patch"
PATCH[1]="buildfix_kernel_6.8-nv_drm_ioctls-DRM_UNLOCKED-is-now-the-default-behavi.patch"
PATCH[2]="buildfix_kernel_6.8-gpl-pfn_valid.patch"
PATCH[3]="nvidia-drm-hotplug-workqueue.patch"
PATCH[4]="nvidia-drm-take-modeset-ownership-earlier.patch"

At 0 to 2 exist now, but 3 and 4 not in 545.