Comment 34 for bug 1925522

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

Performed a review of the remaining 2 NEW packages. Non-blocking issues for libnvidia-nscq-*

 - Build-Depends on a non-versioned debhelper?
 - Same as above, debian/rules BRANCH variable is set to 999
 - Same as above, weird `rm -f lib*.so` in override_dh_auto_build - cleanup needed

Besides that, I guess all the 4 new packages suffer from some lintian warnings (forgot to mention those earlier). Possibly good to have some overrides for those that make no sense, but I'm listing some that would be good to fix:

W: libnvidia-nscq-460 source: ancient-standards-version 3.8.0 (released 2008-06-04) (current is 4.5.0)
W: libnvidia-nscq-460 source: override_dh_fixperms-does-not-call-dh_fixperms (line 124)
W: libnvidia-nscq-460 source: package-uses-deprecated-debhelper-compat-version 9

Still, I think it's non-blocking for a package of this caliber.