Comment 8 for bug 302339

Revision history for this message
David Futcher (bobbo) wrote :

Hi

Thanks for submitting your patch. I have looked at it, but don't think it is ready to be included in Ubuntu yet:

1 - The changelog entries are not written in standard changelog "style". For example, this is what I would have made the changelog:

nss-updatedb (10-1ubuntu2) jaunty; urgency=low

  * debian/control: Add libpam-ldap and libnss-ldap to Suggests (LP: #302339)

 -- Gabriel Ruiz Manzano <email address hidden> Sun, 07 Dec 2008 10:42:17 -0300

2 - The Debian maintainer doesn't agree with the changes (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=508057#10). You probably want to work with him until we know exactly what we should put in Suggests.

3 - Your patch includes direct changes in config.sub and config.guess. This is probably due to a malfunctioning debian/rules file.

Please correct these problems and upload another candidate debdiff and re-subscribe ubuntu-universe-sponsors.

Thanks,
David