I've been looking into integrating the patch into Debian. The spelling fix was easy so that will be done with the next upload ;)
However, I have a few questions about the upstart scripts:
- Why was the init script dropped? Isn't it better to keep both so that systems without upstart can still start nslcd?
- Why was the script split into two parts?
- Are you sure the upstart script should exit with status 1 if it is not cofigured to start (sasl_mech isn't set in nslcd.conf)?
- Why are both scripts logging to /tmp with a predictable name?
- A lot of checks are duplicated in the pre-start script and the script. Isn't there a nicer way of avoiding this duplication?
Can you explain what the extra suggestions add (I'm not much of a Kerberos user myself)?
I've been looking into integrating the patch into Debian. The spelling fix was easy so that will be done with the next upload ;)
However, I have a few questions about the upstart scripts:
- Why was the init script dropped? Isn't it better to keep both so that systems without upstart can still start nslcd?
- Why was the script split into two parts?
- Are you sure the upstart script should exit with status 1 if it is not cofigured to start (sasl_mech isn't set in nslcd.conf)?
- Why are both scripts logging to /tmp with a predictable name?
- A lot of checks are duplicated in the pre-start script and the script. Isn't there a nicer way of avoiding this duplication?
Can you explain what the extra suggestions add (I'm not much of a Kerberos user myself)?