Folks, this bug is now 20 months old, and still no solution to this.
This is really bad practice to just ignore such bug reports since we deal here with a security-related library, and you make folks more and more accept compiler warnings which seem to be fixable from your side. When I f.e. compile a project like libcurl with NSS support these warnings in prlink.h add up to ~100 times! And disabling the warnings with -Wno-strict-prototypes is really not a solution.
BTW. I found some more places where I get similar warnings:
--- cert.h.orig 2009-07-01 01:05:24.000000000 +0200
+++ cert.h 2009-09-06 18:11:04.000000000 +0200
@@ -1610,25 +1610,25 @@
* Returns a pointer to a static structure.
*/
extern const CERTRevocationFlags*
-CERT_GetPKIXVerifyNistRevocationPolicy();
+CERT_GetPKIXVerifyNistRevocationPolicy(void);
/*
* Returns a pointer to a static structure.
*/
extern const CERTRevocationFlags*
-CERT_GetClassicOCSPEnabledSoftFailurePolicy();
+CERT_GetClassicOCSPEnabledSoftFailurePolicy(void);
/*
* Returns a pointer to a static structure.
*/
extern const CERTRevocationFlags*
-CERT_GetClassicOCSPEnabledHardFailurePolicy();
+CERT_GetClassicOCSPEnabledHardFailurePolicy(void);
/*
* Returns a pointer to a static structure.
*/
extern const CERTRevocationFlags*
-CERT_GetClassicOCSPDisabledPolicy();
+CERT_GetClassicOCSPDisabledPolicy(void);
/*
* Verify a Cert with libpkix
@@ -1662,7 +1662,7 @@
/* The function return PR_TRUE if cert validation should use
* libpkix cert validation engine. */
-PRBool CERT_GetUsePKIXForValidation();
+PRBool CERT_GetUsePKIXForValidation(void);
SEC_END_PROTOS
I think you should just apply the void fix, and as time passes by we will see if others will report new problems with the fixes (which I doubt).
Folks, this bug is now 20 months old, and still no solution to this. prototypes is really not a solution. lags* rifyNistRevocat ionPolicy( ); rifyNistRevocat ionPolicy( void);
This is really bad practice to just ignore such bug reports since we deal here with a security-related library, and you make folks more and more accept compiler warnings which seem to be fixable from your side. When I f.e. compile a project like libcurl with NSS support these warnings in prlink.h add up to ~100 times! And disabling the warnings with -Wno-strict-
BTW. I found some more places where I get similar warnings:
--- cert.h.orig 2009-07-01 01:05:24.000000000 +0200
+++ cert.h 2009-09-06 18:11:04.000000000 +0200
@@ -1610,25 +1610,25 @@
* Returns a pointer to a static structure.
*/
extern const CERTRevocationF
-CERT_GetPKIXVe
+CERT_GetPKIXVe
/* lags* cOCSPEnabledSof tFailurePolicy( ); cOCSPEnabledSof tFailurePolicy( void);
* Returns a pointer to a static structure.
*/
extern const CERTRevocationF
-CERT_GetClassi
+CERT_GetClassi
/* lags* cOCSPEnabledHar dFailurePolicy( ); cOCSPEnabledHar dFailurePolicy( void);
* Returns a pointer to a static structure.
*/
extern const CERTRevocationF
-CERT_GetClassi
+CERT_GetClassi
/* lags* cOCSPDisabledPo licy(); cOCSPDisabledPo licy(void) ;
* Returns a pointer to a static structure.
*/
extern const CERTRevocationF
-CERT_GetClassi
+CERT_GetClassi
/*
* Verify a Cert with libpkix
@@ -1662,7 +1662,7 @@
/* The function return PR_TRUE if cert validation should use ForValidation( ); ForValidation( void);
* libpkix cert validation engine. */
-PRBool CERT_GetUsePKIX
+PRBool CERT_GetUsePKIX
SEC_END_PROTOS
I think you should just apply the void fix, and as time passes by we will see if others will report new problems with the fixes (which I doubt).