You're right. It looks like the unittest passes because it switched to a
string which is passed through.
But the value of 10 in the tests/generate.py for lacp-rate isn't right and
looks like parse is not validating
the string value.
On Fri, Jan 26, 2018 at 11:42 AM, Mathieu Trudel-Lapierre <
<email address hidden>> wrote:
> If it's the case, then this would be a critical bug. However, it looks
> to me like LACP rate is being properly handled, values are 'slow' or
> 'fast', and an integration test exists to validate that.
>
> ** Changed in: nplan (Ubuntu)
> Status: New => Triaged
>
> ** Changed in: nplan (Ubuntu)
> Importance: Undecided => Critical
>
> ** Changed in: nplan (Ubuntu)
> Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox)
>
> ** Changed in: nplan (Ubuntu)
> Status: Triaged => Incomplete
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1745648
>
> Title:
> netplan renders bond lacp-rate as a timevalue should be "fast" or
> "slow"
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/nplan/+bug/
> 1745648/+subscriptions
>
You're right. It looks like the unittest passes because it switched to a
string which is passed through.
But the value of 10 in the tests/generate.py for lacp-rate isn't right and
looks like parse is not validating
the string value.
On Fri, Jan 26, 2018 at 11:42 AM, Mathieu Trudel-Lapierre <
<email address hidden>> wrote:
> If it's the case, then this would be a critical bug. However, it looks /bugs.launchpad .net/bugs/ 1745648 /bugs.launchpad .net/ubuntu/ +source/ nplan/+ bug/ +subscriptions
> to me like LACP rate is being properly handled, values are 'slow' or
> 'fast', and an integration test exists to validate that.
>
> ** Changed in: nplan (Ubuntu)
> Status: New => Triaged
>
> ** Changed in: nplan (Ubuntu)
> Importance: Undecided => Critical
>
> ** Changed in: nplan (Ubuntu)
> Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox)
>
> ** Changed in: nplan (Ubuntu)
> Status: Triaged => Incomplete
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https:/
>
> Title:
> netplan renders bond lacp-rate as a timevalue should be "fast" or
> "slow"
>
> To manage notifications about this bug go to:
> https:/
> 1745648/
>