App icons require shaping at every callsite
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Won't Fix
|
Undecided
|
Cris Dywan | ||
notify-osd (Ubuntu) |
Confirmed
|
Undecided
|
Unassigned |
Bug Description
In list items, showing an app icon in the correct Ubuntu shape requires shaping it when you are using it: ListItem.
<http://
That property is set to "True" by default, but it's not obvious why it should be, and list items aren't the only place that app icons get used.
The result is that several times now, app updates have ended up without the appropriate frame:
- in the System Settings "Updates" list (bug 1354478)
- in the "Notifications" screen
- in the Launcher the frame is unintentionally different (bug 1332119).
Conversely, non-app icons have ended up *with* the frame by mistake:
- "Display language" (bug 1288866)
- "Orientation Lock" (bug 1365450)
- Ubuntu updates (bug 1367136).
In notification bubbles, the opposite applies -- you have to set a hint to use an *unshaped* icon: notify_
<https:/
Predictably, this has resulted in cases of icons having frames when they shouldn't:
- Wi-Fi network authentication (bug 1346904)
- alarms (bug 1346925)
- Remove Account (bug 1350282).
On the API design quality scale, both of these are roughly "Read the implementation and you'll get it right." <http://
I suggest that the toolkit move all the way up to "It's impossible to get wrong", by always shaping an icon when it is an app icon, and never otherwise. Whether an icon is an app icon could (I assume) be detected by its path.
description: | updated |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Christian Dywan (kalikiana) |
status: | New → Confirmed |
affects: | ubuntu-ui-toolkit (Ubuntu) → ubuntu-ui-toolkit |
Do we have some code examples? Where do app icons come from? I don't know how consistent the path is… doing magic on arbitrary path names may or may not make it even more confusing when the outcome changes depending on the image.