Comment 29 for bug 1779863

Revision history for this message
Nicolas Noble (grumpycoder) wrote :

I'm sorry, but I must heavily disagree with the assessment here, and I am asking you to reconsider your "won't fix". No breakage is possible since there can't be existing native modules built manually by people due to this other bug, which is the corollary of this present one: https://github.com/nodejs/node-gyp/issues/1415 - node-gyp may be able to fix this in the future somehow and detect and use the system's headers in the case of a mismatch, but it's currently not the case.

Basically, node's build system is exposing OpenSSL 1.0 headers to native addons at build time, which are themselves API compatible with the prebuilt OpenSSL 1.1 library. Therefore, it's impossible to currently build any native addon manually on Ubuntu's nodejs that depend on OpenSSL.

In other words, you can't break existing native modules built by people, because people can't build native modules *due to this bug*. Your rejection is based on an uroboros where you don't want to fix the problem because you're afraid of breaking people that do not exist due to the problem you're rejecting to fix.

If you prefer, I can file a new bug to talk about the fact that you can't currently build native addons that depend on OpenSSL due to mismatching building headers from nodejs' build system and the API you're exposing, but this really is the same resolution than this current bug here.