Comment 7 for bug 1262710

Valentin V. Bartenev (vbart) wrote :

Thanks for the review.

Just a few quick comments:

> - ngx_devpoll_process_events() is missing an argument for a format specifier

Already fixed in mainline: http://hg.nginx.org/nginx/rev/6b479db5b52b

> I'd love to see a static analyzer that can check for additional errors.

We use Coverity on a regular basis: https://scan.coverity.com/projects/158

> There's some oddly asymmetric code around the bl->waiting++ in or out of
> an #if 0 block in these functions, one or the other may be a mistake:
> - ngx_http_busy_lock_cacheable()
> - ngx_http_busy_lock()

Actually the whole code in ngx_http_busy_lock.(h|c) are dead and not compiled.