Comment 77 for bug 1754671

>> dns: introduce routing domains

+ if (domain[0] == '~' && search_only)
+ continue;

+ if (domain[0] == '~') {
+ if (search_only)
+ continue;
+ }

I don't mind which, but let's make it consistent.

>> libnm-core,cli: add support for DNS default property

+ * name servers specified by this connection. When set to %FALSE, such
+ * queries are sent through all connections, excluding VPNs that provide
+ * a search list.

this is not clear to me. Instead of "When set to %FALSE,...", should it be:
"when no currently active connections have this property set to %TRUE, ..."

>> dns: add 'default' attribute to exported DNS entries

+ /* Add default */
+ g_variant_builder_add (&entry_builder,
+ "{sv}",
+ "default",
+ g_variant_new_boolean (is_default));

maybe only add the "default" key, if the value is actually TRUE. A missing value already means FALSE. The reason would be, not to teach users to rely on "default" being present.

minor fixup commits pushed.

the rest lgtm